-
Notifications
You must be signed in to change notification settings - Fork 136
Support for serde serialize and deserialize #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for serde serialize and deserialize #48
Conversation
This was supposed to be a draft PR. There isn't a way to switch it to be a draft PR after you open one so I'll leave this open until it's complete/closed. |
@mystor pointed out that the serde-related compilation failure happens because serde's derive by default expects the serde crate to be called
below each
and it resolved the problem. |
As noted in the PR, X25519 secret keys are unreduced scalars, but the serde implementation for |
36f0c4a
to
d2b32ee
Compare
This looks great! |
853cc8b
to
0c3981d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Start of adding support for serde serialize and deserialize