Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zeroize crate #39

Merged
merged 1 commit into from Nov 26, 2019
Merged

Use zeroize crate #39

merged 1 commit into from Nov 26, 2019

Conversation

DebugSteven
Copy link
Collaborator

This PR removes the use of clear_on_drop and
replaces it with zeroize. The switch to use zeroize would be
nice because the crate has nicer documentation and platform
support. This PR depends on dalek-cryptography/curve25519-dalek#236
and should change theCargo.toml to use a newer version
of curve25519-dalek if this change is accepted.
Currently the Cargo.toml has a git dependency on the
branch I implemented the Zeroize traits for Scalar
and MontgomeryPoint on.

@DebugSteven DebugSteven marked this pull request as ready for review November 26, 2019 20:51
hdevalence
hdevalence approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdevalence hdevalence merged commit b651a5e into dalek-cryptography:develop Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence hdevalence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DebugSteven @hdevalence