Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark selection on the command line seems partially broken #607

Open
oconnor663 opened this issue Dec 12, 2023 · 0 comments
Open

benchmark selection on the command line seems partially broken #607

oconnor663 opened this issue Dec 12, 2023 · 0 comments

Comments

@oconnor663
Copy link

oconnor663 commented Dec 12, 2023

I don't know Criterion well enough to guess at why this is, but the following behavior seems weird. In x25519-dalek and ed25519-dalek I can run benchmarks as tests like this:

cargo bench --all-features -- --test

But running the same command in the curve25519-dalek subdirectory doesn't just run tests, it runs the benchmark suite. Also, adding a filter argument (e.g. cargo bench --all-features xxx) seems to affect what tests run, but it doesn't affect what benchmarks run. Is the benchmark harness in that subdirectory ignoring CLI arguments for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant