Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More a questions about EdwardsPoint rather than issue. #490

Open
SergeStrashko opened this issue Jan 3, 2023 · 4 comments
Open

More a questions about EdwardsPoint rather than issue. #490

SergeStrashko opened this issue Jan 3, 2023 · 4 comments

Comments

@SergeStrashko
Copy link
Contributor

Is there any particular reason why EdwardsPoint is not constructible from [u8;32] ?
Like here in Golang

@tarcieri
Copy link
Contributor

tarcieri commented Jan 3, 2023

It is, albeit by way of CompressedEdwardsY, which is is a newtype for [u8; 32].

That said, a more direct method might be nice.

@tarcieri
Copy link
Contributor

tarcieri commented Jan 5, 2023

I think it might be worth discussing adding an EdwardsPoint::from_bytes API.

@tarcieri tarcieri reopened this Jan 5, 2023
@SergeStrashko SergeStrashko reopened this Jan 5, 2023
@SergeStrashko
Copy link
Contributor Author

SergeStrashko commented Jan 5, 2023

I think implementation will use CompressedEdwardsY underneath anyway, and having two implementations doing exactly the same is root for confusion. I think leaving it as is is good option. And since now there is support for pks8 it might be redundant.

@rozbb
Copy link
Contributor

rozbb commented Aug 28, 2023

I believe #562 gives a method for this. It requires group though. @SergeStrashko does that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants