Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement NEON backend #147

Open
isislovecruft opened this issue Jun 21, 2018 · 5 comments · May be fixed by #457
Open

implement NEON backend #147

isislovecruft opened this issue Jun 21, 2018 · 5 comments · May be fixed by #457
Labels
efficiency - speed enhancement
Milestone
Future Features

Comments

@isislovecruft
Copy link
Member

No description provided.

@isislovecruft isislovecruft self-assigned this Jun 21, 2018
@hdevalence hdevalence added this to the 1.1 milestone Jun 21, 2018
@hdevalence
Copy link
Contributor

As part of this I think it would be good to reorganize the structure of the source tree, if we're going to have multiple vector and serial backends. Right now the tree looks like

backend
├── avx2
│   ├── #edwards.rs#
│   ├── constants.rs
│   ├── edwards.rs
│   ├── field.rs
│   ├── mod.rs
│   └── scalar_mul
│       ├── mod.rs
│       ├── straus.rs
│       ├── variable_base.rs
│       └── vartime_double_base.rs
├── mod.rs
├── u32
│   ├── constants.rs
│   ├── field.rs
│   ├── mod.rs
│   └── scalar.rs
└── u64
    ├── constants.rs
    ├── field.rs
    ├── mod.rs
    └── scalar.rs

and there's a separate hierarchy for the curve_models and the scalar_mul code, which only have the serial algorithms.

I think it might be better to organize the code like

backend
├── mod.rs
├── serial
│   ├── curve_models
│   │   └── mod.rs
│   ├── scalar_mul
│   │   ├── mod.rs
│   │   ├── straus.rs
│   │   ├── variable_base.rs
│   │   ├── vartime_double_base.rs
│   │   └── window.rs
│   ├── u32
│   │   ├── constants.rs
│   │   ├── field.rs
│   │   ├── mod.rs
│   │   └── scalar.rs
│   └── u64
│       ├── constants.rs
│       ├── field.rs
│       ├── mod.rs
│       └── scalar.rs
└── vector
    ├── avx2
    │   ├── constants.rs
    │   ├── field.rs
    │   └── mod.rs
    ├── edwards.rs
    ├── neon
    │   ├── constants.rs
    │   ├── field.rs
    │   └── mod.rs
    └── scalar_mul
        ├── mod.rs
        ├── straus.rs
        ├── variable_base.rs
        └── vartime_double_base.rs

so that the module tree looks more like the actual structure of what parts are common and which aren't.

hdevalence added a commit to hdevalence/curve25519-dalek that referenced this issue Jul 16, 2018
@hdevalence
Clarify wording on the nightly feature and CT
b71f51d 
Closes dalek-cryptography#147
@hdevalence
Copy link
Contributor

I typed the wrong issue number in a commit, this was closed spuriously.

@hdevalence hdevalence reopened this Jul 27, 2018
@hdevalence hdevalence mentioned this issue Aug 2, 2018
Closed
@rubdos
Copy link
Contributor

rubdos commented Dec 14, 2018

Has there been any work on this back end yet? If not, I'm interested in taking a look.

@hdevalence
Copy link
Contributor

I think that @isislovecruft started working on it in the summer. Right now any work on it is blocked on merging #215, which restructures all of the backend code (e.g., making the changes above).

@rubdos
Copy link
Contributor

rubdos commented Dec 15, 2018

Agreed. Give me a ping if you want some man-hours spend on this. It would be very cool to have curve25519-dalek as the fastest library on all platforms :-)

@hdevalence hdevalence removed this from the 1.1 milestone Dec 29, 2018
@hdevalence hdevalence added this to the 1.3 milestone Jun 4, 2019
@isislovecruft isislovecruft removed their assignment Jan 7, 2021
@rubdos rubdos linked a pull request Dec 8, 2022 that will close this issue
Open
5 tasks
pinkforest pushed a commit to pinkforest/curve25519-dalek that referenced this issue Jun 27, 2023
@isislovecruft
Merge pull request dalek-cryptography#147 from isislovecruft/fix/dete…
1335f3a 
…rministic-batch-malleability

batch verification malleability issue when used with fully deterministic nonce generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efficiency - speed enhancement
Projects
None yet
Milestone
Future Features
Development

Successfully merging a pull request may close this issue.

NEON backend for aarch64 rubdos/curve25519-dalek
3 participants
@hdevalence @isislovecruft @rubdos