Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support grouping dot and blank imports at the end #88

Merged
merged 2 commits into from Jul 25, 2022
Merged

Support grouping dot and blank imports at the end #88

merged 2 commits into from Jul 25, 2022

Conversation

mnencia
Copy link
Contributor

@mnencia mnencia commented Jul 21, 2022

Closes #65

@daixiang0
Copy link
Owner

@mnencia thanks for your contribution!

Codes looks good overall, could you help update README(sections, help command and so on)?

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia
Copy link
Contributor Author

mnencia commented Jul 22, 2022

@daixiang0, thanks for the review. I've added the documentation.

@daixiang0
Copy link
Owner

@mnencia LGTM, thanks for your contribution!

@daixiang0 daixiang0 merged commit 30a50b8 into daixiang0:master Jul 25, 2022
@mnencia mnencia deleted the dot-and-blank branch July 25, 2022 04:07
@chialiyun
Copy link

chialiyun commented Aug 10, 2022

hi @mnencia / @daixiang0 , I am getting this error when running via golangci-lint

  • can't run linter goanalysis_metalinter: gci: failed to parse section "Blank": section alias "Blank" not registered with parser

may I ask what am I missing?

I have the following config:

linters-settings:
  gci:
    sections:
      - Blank
    custom-order: true

@daixiang0
Copy link
Owner

@chialiyun which version of golangci-lint do you use?

@chialiyun
Copy link

chialiyun commented Aug 10, 2022

@daixiang0 i am using the latest: golangci-lint has version v1.44.2 built from (unknown, mod sum: "h1:MzvkDt1j1OHkv42/feNJVNNXRFACPp7aAWBWDo5aYQw=") on (unknown)

i installed using brew
i tried brew upgrade golangci-lint and i get

Warning: golangci-lint 1.48.0_1 already installed

@daixiang0
Copy link
Owner

daixiang0 commented Aug 10, 2022

@chialiyun 1.44.2 does not include this feature :(

You can download binary directly to try the latest version which includes this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group dot imports
3 participants