Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dbt-core 1.8+ #21774

Closed
cbini opened this issue May 10, 2024 · 8 comments · Fixed by #21908
Closed

Support dbt-core 1.8+ #21774

cbini opened this issue May 10, 2024 · 8 comments · Fixed by #21908
Assignees
@rexledesma
Labels
integration: dbt Related to dagster-dbt type: feature-request

Comments

@cbini
Copy link
Contributor

cbini commented May 10, 2024

dbt-core just released version 1.8: https://github.com/dbt-labs/dbt-core/releases/tag/v1.8.0

It would be great if we could get this vetted and supported in an upcoming release.

dagster/python_modules/libraries/dagster-dbt/setup.py

Line 40 in b1a12e0

"dbt-core>=1.6,<1.8",

@robele-dooly
Copy link

I can take this

@lydialimlh
Copy link

Would anyone be able to provide an ETA, for compatibility with dbt-core 1.8?

@robele-dooly
Copy link

Would anyone be able to provide an ETA, for compatibility with dbt-core 1.8?

I'm hoping to submit PR in a few hours. I'm not sure if someone else has joined yet

@robele-dooly
Copy link

PR Draft - #21831

@garethbrickman garethbrickman mentioned this issue May 14, 2024
Closed
@rexledesma rexledesma self-assigned this May 14, 2024
@rexledesma
Copy link
Member

I'll handle this in the next week or two. Supporting dbt-core==1.8.* requires some surgery in the framework since some internal methods from dbt-core moved around, so this change isn't as simple as relaxing the pin.

@rexledesma rexledesma mentioned this issue May 16, 2024
Merged
rexledesma added a commit that referenced this issue May 17, 2024
@rexledesma
feat(dbt): support dbt-core==1.8.* (#21908)
7fc3be9 
## Summary & Motivation
Resolves #21774.

## How I Tested These Changes
pytest
@rexledesma
Copy link
Member

Resolved in #21908. Support for dbt-core==1.8.* will come out in dagster==1.7.7 and dagster-dbt==0.23.7!

@cbini
Copy link
Contributor Author

cbini commented May 17, 2024

nice! any chance of an off-cycle release for this?

@rexledesma
Copy link
Member

We're not planning on an off-cycle release for this, since there's a workaround for users (pinning dbt-core<1.8). It will come out next Thursday (5/23).

nikomancy pushed a commit that referenced this issue May 22, 2024
@rexledesma @nikomancy
feat(dbt): support dbt-core==1.8.* (#21908)
bd2181e 
## Summary & Motivation
Resolves #21774.

## How I Tested These Changes
pytest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rexledesma rexledesma

Labels
integration: dbt Related to dagster-dbt type: feature-request
Projects
None yet
Milestone
No milestone
5 participants
@cbini @rexledesma @lydialimlh @garethbrickman @robele-dooly