Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deltalake upper version bound in dagster-polars! #21759

Closed
ion-elgreco opened this issue May 9, 2024 · 2 comments · Fixed by #21841
Closed

Remove deltalake upper version bound in dagster-polars! #21759

ion-elgreco opened this issue May 9, 2024 · 2 comments · Fixed by #21841
Labels
integration: polars Related to dagster-polars

Comments

@ion-elgreco
Copy link
Contributor

Dagster version

1.7.5

What's the issue?

The upper bound of deltalake in dagster-polars needs to be removed.

That one failing test simply needs to be skipped. The issue only happens in edge cases, which I've already fixed in deltalake and will be released in next bugfix release.

It's bad practice, to upper limit a package for such a small bug. For that 0.0001% you might run into an issue, now all environments can't upgrade deltalake if you use dagster-polars...

What did you expect to happen?

No response

How to reproduce?

No response

Deployment type

None

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@ion-elgreco ion-elgreco added the type: bug Something isn't working label May 9, 2024
@garethbrickman garethbrickman added the integration: polars Related to dagster-polars label May 9, 2024
@garethbrickman
Copy link
Contributor

@ion-elgreco Could you let us know when the deltalake bugfix is released? Can then put in a PR for unpinning the version and see how that test goes 👍

@garethbrickman garethbrickman removed the type: bug Something isn't working label May 10, 2024
@ion-elgreco
Copy link
Contributor Author

@garethbrickman I pushed a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: polars Related to dagster-polars
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants