Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"dagster code-server start" and "dagster api grpc" do _not_ take the same arguments #21698

Closed
leejlFG opened this issue May 7, 2024 · 0 comments · Fixed by #21828
Closed

"dagster code-server start" and "dagster api grpc" do _not_ take the same arguments #21698

leejlFG opened this issue May 7, 2024 · 0 comments · Fixed by #21828
Labels
area: docs Related to documentation in general

Comments

@leejlFG
Copy link

leejlFG commented May 7, 2024

What's the issue or suggestion?

Title basically explains it all - auto-reloading the code location via GraphQL in OSS deployments requires the code-server start command in lieu of the api grpc command, but the arguments are not the same as written here and here. The good solution is to make them actually match, but the easy solution is to just not say that they do.

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
@leejlFG leejlFG added the area: docs Related to documentation in general label May 7, 2024
SanjaySiddharth added a commit to SanjaySiddharth/dagster that referenced this issue May 14, 2024
@SanjaySiddharth
Resolution for issue dagster-io#21698
5212788
SanjaySiddharth added a commit to SanjaySiddharth/dagster that referenced this issue May 14, 2024
@SanjaySiddharth
Complete-Resolution for issue dagster-io#21698
f346d2f
@garethbrickman garethbrickman mentioned this issue May 14, 2024
Merged
garethbrickman pushed a commit that referenced this issue May 14, 2024
@SanjaySiddharth
Resolution for issue #21698 (#21828)
14c8d41 
## Summary & Motivation

Resolves #21698

Removed occurrences in documentation where earlier it was mentioned that
"dagster code-server start" and "dagster api grpc" take the same
arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolution for issue #21698 SanjaySiddharth/dagster
1 participant
@leejlFG