Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary-on-demand service #2177

Closed
shykes opened this issue Apr 13, 2022 · 2 comments
Closed

Binary-on-demand service #2177

shykes opened this issue Apr 13, 2022 · 2 comments
Labels
area/cli All about go code on dagger CLI

Comments

@shykes
Copy link
Contributor

shykes commented Apr 13, 2022

We should host a binary-on-demand service eg. get.dagger.io/binary/dagger-$GITREF.tgz that builds the requested version just-in-time for download.

Originally posted by @shykes in dagger/dagger-for-github#35 (comment)

@shykes
Copy link
Contributor Author

shykes commented Apr 13, 2022

As explained by @crazy-max , Docker buildx has something similar that we can take inspiration from. See dagger/dagger-for-github#35 (comment)

We have something like this with our setup-buildx-action. You can define a git repo as version and it will build on-fly buildx and use it: https://github.com/docker/setup-buildx-action/runs/5987865407?check_suite_focus=true#step:3:95

        name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v1
        with:
          version: https://github.com/docker/buildx.git#refs/pull/731/head

It's quite powerful when you want to test a PR with a specific context. Under the hood it uses a Git remote context to build buildx with buildx 😅:

docker buildx build --target binaries --output type=local,dest=/tmp/docker-setup-buildx-8FFA7Y/out https://github.com/docker/buildx.git#refs/tags/v0.5.1

Doing something like this should be possible for dagger too. Here is the PR for ref: docker/setup-buildx-action#99

@shykes shykes added sdk/cue and removed sdk/cue labels Oct 20, 2022
@shykes shykes added area/cli All about go code on dagger CLI and removed area/infra labels Dec 5, 2022
@shykes
Copy link
Contributor Author

shykes commented Mar 25, 2024

I'm giving up on this ever being done.

@shykes shykes closed this as completed Mar 25, 2024
@shykes shykes closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli All about go code on dagger CLI
Projects
None yet
Development

No branches or pull requests

1 participant