Skip to content

Reduce allocations by turning Request into array of struct stack #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dadhi opened this issue Jun 25, 2019 · 1 comment
Closed

Reduce allocations by turning Request into array of struct stack #142

dadhi opened this issue Jun 25, 2019 · 1 comment
Labels
enhancement New feature or request performance

Comments

@dadhi
Copy link
Owner

dadhi commented Jun 25, 2019

Given the successful example in FEC with BlockInfo stack, it is likely will work with Request.
Here we will get automatic pooling (or reusing) of Request objects. The phisical length of stack will be equal to the deepest branch.
@dadhi dadhi added enhancement New feature or request performance labels Jul 25, 2019
@dadhi dadhi changed the title [Perf] Reduce allocations by turning Request into array of struct stack Reduce allocations by turning Request into array of struct stack Jul 25, 2019
@dadhi
Copy link
Owner Author

dadhi commented Jul 25, 2019

Wrapping the stack of requests into separate single object will help to track
a shared context, e.g. for #153

dadhi added a commit that referenced this issue Sep 21, 2019
@dadhi
added initial test for #142
9671681
@dadhi dadhi closed this as completed in 4c2d066 Sep 21, 2019
Leszek-Kowalski pushed a commit to Leszek-Kowalski/DryIoc that referenced this issue Oct 11, 2019
@dadhi @Leszek-Kowalski
added initial test for dadhi#142
9590a56
dadhi pushed a commit that referenced this issue Sep 1, 2020
adding the docs for the #142
9d2aa47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dadhi