Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborations with JSON5's standardization #2

Open
DonaldTsang opened this issue Jun 15, 2019 · 2 comments
Open

Collaborations with JSON5's standardization #2

DonaldTsang opened this issue Jun 15, 2019 · 2 comments

Comments

@DonaldTsang
Copy link

See json5/json5#190 for more info

@d3x0r
Copy link
Owner

d3x0r commented Jun 15, 2019

Thanx for the heads up;; I'll consider my response :)

@d3x0r
Copy link
Owner

d3x0r commented Nov 12, 2019

Again, thank you for the heads up; I was hoping a community of similar minds might help solve some of my questions about where/how to go from here.
But; this has been quite complete for a while (although I have rattled a few edge cases loose recently), I've been using this continuously for simple things like dates and simplified message formatting... {op:"doSomething,arg:"blah"}
Sorry, I'm rambling a bit...
I did like the idea of implementing some round-tripping of comments; but this implementation isn't even 2 layers like the C node plugin, which parses the tree into a abstract tree, and then converts that to JS objects, this converts the objects as it goes along; which has caused issues reviving a structure which points to itself as the first member of some child structure :) But, without the multiple passes, I don't even have a place to save the comments at this time....

I have though that a potential speedup/rearchitect of this would do a high level scan of structure characters []{}:, and if one was clever really just : and , to get the shape of it, and perhaps save the start of identifier/string references, and a second pass to massage it into real objects; in C, this would let me measure early, allocate all the working space, in one block, and then parse into it....
But, that also assumes that the content being parsed is already completed, and isn't a partial stream of packets...

@d3x0r d3x0r changed the title Collaborations with JSON5's statndardization Collaborations with JSON5's standardization Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants