Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition.{attr,style} should use interpolateNumber if the target value is a number. #87

Closed
mbostock opened this issue Jan 21, 2019 · 0 comments

Comments

@mbostock
Copy link
Member

#67 fixed the short-circuit comparison when transition.attr or transition.style is passed a constant, but changed the interpolator to use interpolateString rather than interpolateNumber. (And I don’t recall my reasoning in #67 (comment), since the interpolator is chosen based on the target value, not the current value.) We should still use interpolateNumber if the target value is a number.

@mbostock mbostock changed the title interpolateNumber should be used if the target value is a number. transition.{attr,style} should use interpolateNumber if the target value is a number. Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant