Adopt type=module #123
Merged
Adopt type=module #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow changes in d3-format: * type=module * add exports * remove zip * license: ISC * update dependencies **TESTS NOT WORKING**
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow changes in d3-format:
TESTS NOT WORKING I'm sharing this in a half-baked state because it's too hard for me. I hope someone will pick it up. Some errors are easy to fix (like const that need to be changed to let), but the crux of the thing is understanding how d3-transition attaches itself to d3-selection, as well as fixing the issues with the d3-selection tests (see d3-selection d3/d3-selection#276) and the d3-timer tests (d3/d3-timer#46).
TODO: