Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precise sideEffects. #115

Merged
merged 1 commit into from Jun 7, 2021
Merged

Precise sideEffects. #115

merged 1 commit into from Jun 7, 2021

Conversation

mbostock
Copy link
Member

No description provided.

@mbostock mbostock requested a review from Fil August 27, 2020 23:19
Copy link
Member

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the simple webpack application I describe in d3/d3#3131 (comment) I manually applied this edit in node_modules/d3-transition/package.json and ran npx webpack.

The resulting page was in error: vt.style(...).transition is not a function

main.js  26.3 KiB       0  [emitted]  main
Entrypoint main = main.js
 [6] ./node_modules/d3-selection/src/selection/index.js + 36 modules 22.8 KiB {0} [built]
     |    37 modules
[17] ./node_modules/d3-selection/src/pointer.js + 1 modules 829 bytes {0} [built]
     |    2 modules
[43] ./src/index.js + 35 modules 70.1 KiB {0} [built]
     | ./src/index.js 166 bytes [built]
     |     + 35 hidden modules
    + 465 hidden modules

@mbostock
Copy link
Member Author

How about now?

@Fil
Copy link
Member

Fil commented Aug 29, 2020

97750a8 works 👍

main.js  38.1 KiB       0  [emitted]  main
Entrypoint main = main.js
[31] ./src/index.js + 114 modules 123 KiB {0} [built]
     | ./src/index.js 155 bytes [built]
     |     + 114 hidden modules
    + 425 hidden modules

@mbostock mbostock merged commit 1ac7984 into main Jun 7, 2021
@mbostock mbostock deleted the some-side-effects branch June 7, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants