Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition.end() never resolves if 0 elements are matched #105

Closed
chahu opened this issue May 8, 2020 · 2 comments
Closed

transition.end() never resolves if 0 elements are matched #105

chahu opened this issue May 8, 2020 · 2 comments

Comments

@chahu
Copy link

chahu commented May 8, 2020

The subject says it all. I was debugging some more complex d3 code and this behavior turned out to be the culprit. Here's a stripped down example.

https://codepen.io/chahu/pen/KKdomVZ

@Fil
Copy link
Member

Fil commented Jul 8, 2020

In that case no schedule has been set on any node, there is nothing to end. We should probably resolve immediately (as in #108), but it might not the behavior you would expect if you'd set a fixed duration.

@chahu
Copy link
Author

chahu commented Jul 8, 2020

Thanks for looking into this. Based on #108, resolving immediately seems more consistent, but either behavior is reasonable in my eyes.

@Fil Fil closed this as completed in baaf0dd Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants