Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sideEffects in package.json? #223

Closed
mindrones opened this issue Aug 4, 2019 · 1 comment
Closed

Add sideEffects in package.json? #223

mindrones opened this issue Aug 4, 2019 · 1 comment

Comments

@mindrones
Copy link

mindrones commented Aug 4, 2019

It would be nice to know if a d3 module has side effects without having to read the code, by inspecting the sideEffects property in package.json.

This would permit to enhance tree shaking by reading that value programmatically and set rollup's treeshake.moduleSideEffects accordingly.

If this makes sense and is doable, this would apply to all of d3 modules (EDIT: especially if you'll do a major version bump across all the modules!)

Thanks!

@mbostock
Copy link
Member

mbostock commented Aug 5, 2019

Duplicate of d3/d3#3131. This is planned, but please see caveats in that discussion and comments would be welcome.

@mbostock mbostock closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants