Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleDiverging for domain [1,1,0] produces wrong results #256

Open
MaPePeR opened this issue Sep 25, 2021 · 1 comment
Open

scaleDiverging for domain [1,1,0] produces wrong results #256

MaPePeR opened this issue Sep 25, 2021 · 1 comment

Comments

@MaPePeR
Copy link

MaPePeR commented Sep 25, 2021

The d3.scaleDiverging Method returns wrong results if the domain is reverted and the left domain border is equal to the midpoint.

const s = d3.scaleDiverging().domain([1, 1, 0]);
for (const i of [-0.5, 0, 0.25, 0.5, 0.75, 1, 1.5]) {
    console.log(i, s(i));
}
/* prints
-0.5     0.5
 0       0.5
 0.25    0.5
 0.5     0.5
 0.75    0.5
 1       0.5
 1.5     0.25
*/

Having the domain sorted and applying 1-x to the scale produces the expected results:

const s = d3.scaleDiverging().domain([0, 1, 1]);
for (const i of [-0.5, 0, 0.25, 0.5, 0.75, 1, 1.5]) {
    console.log(i, 1 - s(i));
}
/* prints
-0.5     1.25
 0       1
 0.25    0.875
 0.5     0.75
 0.75    0.625
 1       0.5
 1.5     0.5
*/

I encountered this because I wanted to use the RdBu colormap and map values [0,1] to [0.5,1] (blue part) and [1,max(data)] to [0, 0.5] (red part):

const colorMap = d3.scaleDiverging().domain([Math.max(maxValue, 1), 1, 0]).interpolator(d3.interpolateRdBu);

and had to change it to this:

const colorMap = d3.scaleDiverging().domain([0, 1, Math.max(maxValue, 1)]).interpolator(x => d3.interpolateRdBu(1 - x));

I use https://cdn.jsdelivr.net/npm/d3@7.0.1/dist/d3.min.js.

@mbostock
Copy link
Member

Right, diverging scales don’t currently support reversed (or “descending”) domains. We’d need to add that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants