scaleQuantile performance fixup #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
approved these changes
Sep 23, 2020
Fil
approved these changes
Sep 23, 2020
|
This is missing a change to package.json: if we adopt quantileSorted, then we need d3-array 2.3.0 or higher. I’ll fix. |
|
Just realized it should be bumped, but I see that you're already ahead of me and published a new release as well. That was fast, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed a significant performance drop since upgrading to newer version of
d3-scale. Based on profiling that we've done it was apparent thatscaleQuantilewas taking much longer to complete for the same input.By inspecting the code it looks like it's calling out to
d3-array::quantile, which creates a copy of the array (640k entries in our case) and re-sorts it each time. Since our input is already sorted, and the previous version of this function did not do in-place sorting, usingd3-array::quantileSortedinstead ofd3-array::quantilegets the performance back to regular execution times.d3-arrayaddedquantileSortedin this commit, I assume this update is an expected outcome as it restores the behavior it had prior to this change.