Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-cancelable event #70

Closed
rowanc1 opened this issue Apr 29, 2020 · 3 comments
Closed

Non-cancelable event #70

rowanc1 opened this issue Apr 29, 2020 · 3 comments

Comments

@rowanc1
Copy link

rowanc1 commented Apr 29, 2020

I am getting errors in the noevent.js file saying:

Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

The advice I have seen around the internet is to add a:

export default function() {
  if (event.cancelable) event.preventDefault();
  event.stopImmediatePropagation();
}

image

Let me know if you want me to open a PR!


Version: 1.2.5
Using: Chrome 81.0.4044.122 (in emulator)
Platform: Mac

@Fil
Copy link
Member

Fil commented Jul 24, 2020

This seems similar to d3/d3-zoom#195 and d3/d3-zoom#175 ; it would be nice to be able to reproduce the issue with a given webpage and browser.

@AVatch
Copy link

AVatch commented Nov 3, 2020

This happens to me as well in an Ionic (https://ionicframework.com/) project with the touch inputs turned on in Chrome.

I suspect it may be related to the ion-content since it has it's own scroll logic.

@mbostock
Copy link
Member

mbostock commented Jun 9, 2021

I believe this was because the event listeners were not declared non-passive, which was the historical default, but broken in recent browsers. Hence, this is a duplicate of #78 which is now fixed.

@mbostock mbostock closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants