Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability fix for d3-color nice-to-have in version 1.x #109

Open
danisluk opened this issue Oct 7, 2022 · 4 comments
Open

Comments

@danisluk
Copy link

danisluk commented Oct 7, 2022

Please, would it be possible to backport the fix made in #100 to d3-color 1.x ?

There are multiple people, who would be happy for this backport.

@mbostock
Copy link
Member

mbostock commented Oct 7, 2022

I’m not going to do this but you are welcome to fork this repository.

@mpopv
Copy link

mpopv commented Oct 21, 2022

1.x fork here with fix cherry-picked: https://www.npmjs.com/package/d3-color-1-fix

Install package and point to it with "d3-color": "npm:d3-color-1-fix" in "resolutions" (yarn) or "overrides" (npm).

@uwang
Copy link

uwang commented Oct 31, 2022

After I change to:

{
    "resolutions": {
        "d3-color": "https://registry.npmmirror.com/d3-color-1-fix/-/d3-color-1-fix-1.4.2.tgz"
    }
}

It works. But audit always need 3.1.0

@mpopv
Copy link

mpopv commented Nov 8, 2022

I'd recommend not using the tgz directly because it can't be audited like a package by automated tooling.

You're also probably going to want to manually search your lockfile after adding the override to make sure vulnerable versions of d3-color are expunged; there are some versions of npm (<8.7, I believe) where lockfile generation for overrides was broken so it would not be properly expunged and you will trip automated vulnerability checkers even with the override added properly in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants