Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop calling quantile without p #262

Closed
wants to merge 1 commit into from
Closed

Infinite loop calling quantile without p #262

wants to merge 1 commit into from

Conversation

jleedev
Copy link

@jleedev jleedev commented Sep 20, 2022

e.g.

> quantile([1,2,3])                                                             
^CUncaught Error: Script execution was interrupted by `SIGINT`

While the quantile function might wish to define a specific error or default behavior, the underlying cause is quickselect shuffling elements between integral indices and "undefined"; this is obviously nonsensical and quickselect should instead complain about an invalid pivot index.

@mbostock mbostock closed this in 2e7ffcc Dec 3, 2022
@jleedev jleedev deleted the patch-1 branch December 3, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant