fix Scott’s rule #246
Merged
fix Scott’s rule #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cbrt is more precise than pow(1/3), and faster on Chrome (but on Safari and Firefox the performance is almost identical). None of this matters here :)
|
Fil
approved these changes
Apr 1, 2022
Right, but is cbrt(1/x) more precise (or faster) than pow(x, -1/3)? |
|
I've added those to the test notebook, it doesn't seem to change anything in terms of speed. As for accuracy I don't know what would be relevant. https://observablehq.com/@fil/math-cbrt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not sure how this happened, but all the literature uses 3.49, but d3-array used 3.5 for some reason.
I also thought about switching to
Math.cbrt(1 / count(values))but I’m not sure if that’s an improvement.