Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle undefined order #227

Merged
merged 7 commits into from Aug 16, 2021
Merged

handle undefined order #227

merged 7 commits into from Aug 16, 2021

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Aug 14, 2021

Supersedes #219. Fixes #217.

  • d3.bisect (and d3.bisector)
  • d3.sort (and d3.groupSort)
  • d3.quickselect

I’m excited by how this turned out!

@mbostock mbostock requested a review from Fil August 14, 2021 16:13
@mbostock mbostock changed the title handle undefined during bisection handle undefined order Aug 14, 2021
@mbostock mbostock mentioned this pull request Aug 14, 2021
@mbostock mbostock merged commit 22cdb3f into main Aug 16, 2021
@mbostock mbostock deleted the mbostock/undefined-order branch August 16, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

sort(A) and sort(A, d => d) are not equivalent
2 participants