Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.29.x] Add support of const fused type memory views (GH-3118) #5076

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[0.29.x] Add support of const fused type memory views (GH-3118) #5076

merged 1 commit into from
Jan 4, 2023

Conversation

da-woods
Copy link
Contributor

@da-woods da-woods commented Oct 9, 2022

Cherry-pick candidate for 0.29.x - the actual change outside the tests is really pretty tiny. Would fix #3783

@jbrockmendel
Copy link
Contributor

Nice! I’ve been looking forward to using these

@scoder scoder added this to the 0.29.33 milestone Jan 4, 2023
@scoder scoder merged commit 08e4478 into cython:0.29.x Jan 4, 2023
@scoder scoder mentioned this pull request Jan 4, 2023
Closed
@da-woods da-woods deleted the cherrypick-const-fused branch January 4, 2023 10:18
@braingram braingram mentioned this pull request Jan 4, 2023
Closed
@jjerphan
Copy link
Contributor

jjerphan commented Jan 5, 2023

Thank you a lot for back-porting this fix to 0.29.X. This will ease scikit-learn's Cython implementations and maintenance significantly. 💯

@thrasibule thrasibule mentioned this pull request May 22, 2023
Merged
@steppi steppi mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cython Language Feature defect
Projects
None yet
Milestone
0.29.33
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@da-woods @jbrockmendel @jjerphan @scoder @t20100