Fix a large chunk of exc_info changes on 0.29.x #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By disabling CYTHON_FAST_THREAD_STATE and CYTHON_USE_EXC_INFO_STACK I think this still leaves some breakage in Coroutines.c but it's enough of a fix that Cython succeeds in building itself. Therefore I think it's worth doing now even if it doesn't fix everything. Related to cython#4500
|
Right. I think this is the safest we can do for 0.29.x. |
|
I can't actually see any test failures related to this, so it's possibly a more complete fix than I originally thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By disabling CYTHON_FAST_THREAD_STATE and CYTHON_USE_EXC_INFO_STACK
I think this still leaves some breakage in Coroutines.c but it's
enough of a fix that Cython succeeds in building itself. Therefore
I think it's worth doing now even if it doesn't fix everything.
Related to #4500