tweak 1027db04 for older versions of PyPy #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Ah, sorry for that. I should have checked at the time. I just remembered (apparently incorrectly) that this was an older change. |
|
Would it be ok to backport this patch? |
scoder
pushed a commit
that referenced
this pull request
Feb 4, 2022
|
Picked for 0.29.x in 2d287a6 |
|
Thanks Stefan! 😄 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 1027db0, the qualification for PyPy was removed from this
#ifdef. That will break pypy users for v7.3.3 and earlier (pypy v7.3.4 was released 2021-04-08). This PR replaces that commit with a more nuanced version.xref #4234