Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG not produced by release process #722

Closed
MikeMcC399 opened this issue Jan 11, 2023 · 3 comments
Closed

CHANGELOG not produced by release process #722

MikeMcC399 opened this issue Jan 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Jan 11, 2023

Problem description

Although the release job in the .github/workflows/main.yml is set up with the extra_plugins: parameter @semantic-release/changelog no changelog is generated:

      - name: Semantic Release
        uses: cycjimmy/semantic-release-action@v3
        id: semantic
        with:
          branch: master
          extra_plugins: |
            @semantic-release/git
            @semantic-release/changelog

Steps to reproduce the issue

View https://github.com/cypress-io/github-action and note that there is no file CHANGELOG.md present.

View the release log for PR #677 which triggered release v5.0.1 automatically.

Note that no changelog is called. If there were, then it would appear as:

 › ℹ  Start step "prepare" of plugin "@semantic-release/changelog"

Expected behavior

When a release is generated through cycjimmy/semantic-release-action then a CHANGELOG.md should be created or updated in https://github.com/cypress-io/github-action.

Analysis

The documentation for cycjimmy/semantic-release-action: extra_plugins says:

"When using this option, please make sure that these plugins are also mentioned in your semantic release config's plugins array."

Referring to the related documentation about semantic-release's configuration file, none of the options has been set:

  • A .releaserc file, written in YAML or JSON, with optional extensions: .yaml/.yml/.json/.js
  • A release.config.js file that exports an object
  • A release key in the project's package.json file

This is the reason that no CHANGELOG.md has been created.

Suggested Fix

Create the file https://github.com/cypress-io/github-action/.releaserc with the contents:

{
  "plugins": [
    "@semantic-release/commit-analyzer",
    "@semantic-release/release-notes-generator",
    "@semantic-release/changelog",
    "@semantic-release/npm",
    "@semantic-release/github",
    "@semantic-release/git"
  ]
}

This also fixes the issue that @semantic-release/git does not run, for the same reason that it is also not correctly configured.

References

@MikeMcC399
Copy link
Collaborator Author

@mjhenkes mjhenkes added the bug Something isn't working label Mar 9, 2023
@mjhenkes mjhenkes removed their assignment Mar 13, 2023
@mschile
Copy link

mschile commented May 3, 2023

@MikeMcC399, I think we should just remove the extra_plugins from the workflow and use the release notes on the GitHub release instead of adding a changelog.

@MikeMcC399
Copy link
Collaborator Author

@mschile

I think we should just remove the extra_plugins from the workflow and use the release notes on the GitHub release instead of adding a changelog.

That's OK with me.

I'll close the current PR and submit a new one to clean things up.

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants