Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-action version usage and guidelines #671

Closed
MikeMcC399 opened this issue Dec 15, 2022 · 1 comment
Closed

github-action version usage and guidelines #671

MikeMcC399 opened this issue Dec 15, 2022 · 1 comment

Comments

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Dec 15, 2022

What are the current best practice guidelines for specifying the version of github-action to use?

https://docs.cypress.io/guides/continuous-integration/github-actions#Explicit-Version-Number shows:

Explicit version GHA

whereas https://github.com/cypress-io/github-action#explicit-version is not so outspoken about using a full version tag:

Explicit version GHA 2

Doesn't GHA update the major version number when there are breaking changes? Is it really "best practice" to use a full version tag, which means that when minor versions or patches are published, they won't be automatically used.

In any case, the document https://docs.cypress.io/guides/continuous-integration/github-actions should be updated to align with PR #668 which updates to v5.

See also guidance in GitHub Actions toolkit

"Recommendation: bind to major versions to get functionality and fixes but reserve binding to a specific release or SHA as a mitigation strategy for unforeseen breaks."

which seems to apply here as well.

@MikeMcC399
Copy link
Collaborator Author

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant