Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Annotations warnings from example-chrome workflow #670

Merged
merged 1 commit into from Dec 19, 2022

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Dec 14, 2022

This PR resolves issue #669 "CI: Workflow chrome shows Annotations warnings".

It updates the example workflow .github/workflows/example-chrome.yml by

  1. correcting the paths for artifact uploads. Adds v9 for v9 tests.
  2. ensuring that the artifact names are unique. Appends -v10 to v10 tests.
  3. converting the incorrect parameter headless: true to headed: false

Edit: In addition, as requested, the v9 test, and artifacts produced by it, have -v9 added to their labels.

Verification

View the action logs for https://github.com/cypress-io/github-action/actions/workflows/example-chrome.yml and check that there are no longer any Annotations warnings.

The count of Artifacts should show 10.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator Author

Referring to 3697951349:

  1. There are no Annotations warnings shown
  2. 10 Artifacts have been uploaded

so the PR is working as desired.

@MikeMcC399 MikeMcC399 force-pushed the fix/example-chrome branch 2 times, most recently from 3779d04 to e740df6 Compare December 15, 2022 17:38
@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 15, 2022 17:38
@MikeMcC399
Copy link
Collaborator Author

The action log 3706533047 shows that the Annotations warnings no longer appear.

This PR can be merged now.

Make artifacts use correct source paths for upload
Make labels consistent for v9 and v10
Correct headed parameter
@MikeMcC399
Copy link
Collaborator Author

The v9 test and artifacts from it are now explicitly labelled with -v9 as requested:

Chrome test labels

@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 17, 2022 07:49
Copy link
Member

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jaffrepaul jaffrepaul merged commit 0a25799 into cypress-io:master Dec 19, 2022
@MikeMcC399 MikeMcC399 deleted the fix/example-chrome branch December 19, 2022 21:14
@github-actions
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot added a commit to weareinreach/InReach that referenced this pull request Dec 20, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout) | action | digest | `7dd9e2a` -> `755da8c` |
| [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `0ec8cd8` -> `2440d35` |
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.0` -> `v5.0.2` |
| [github/codeql-action](https://togithub.com/github/codeql-action) | action | digest | `a669cc5` -> `959cbb7` |
| [tinkurlab/monorepo-pr-labeler-action](https://togithub.com/tinkurlab/monorepo-pr-labeler-action) | action | patch | `4.1.2` -> `4.1.3` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.2`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.2)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.1...v5.0.2)

Numerous housekeeping updates to bring this action back up to speed.

\*In combination with v5.0.1, which triggered without a new dist build.

👏 Special thanks to [@&#8203;MikeMcC399](https://togithub.com/MikeMcC399) for all the diligent work! 👏

**Fix Failed Tests**

-   [cypress-io/github-action#643
-   [cypress-io/github-action#658
-   [cypress-io/github-action#660

**Update Dependencies**

-   [cypress-io/github-action#644
-   [cypress-io/github-action#650

**Resolve Warnings**

-   [cypress-io/github-action#651
-   [cypress-io/github-action#666
-   [cypress-io/github-action#670
-   [cypress-io/github-action#675

**Docs/Example Updates**

-   [cypress-io/github-action#665
-   [cypress-io/github-action#668

**Tooling Updates:**

-   [cypress-io/github-action#667
-   [cypress-io/github-action#677

### [`v5.0.1`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.1)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.0...v5.0.1)

##### Bug Fixes

-   correct .gitignore for videos and screenshots ([89e59e5](https://togithub.com/cypress-io/github-action/commit/89e59e5cfc7760513fe9e9ce4c690345d94eb27a))

</details>

<details>
<summary>tinkurlab/monorepo-pr-labeler-action</summary>

### [`v4.1.3`](https://togithub.com/TinkurLab/monorepo-pr-labeler-action/releases/tag/4.1.3): Monorepo PR Labeler v4.1.3

[Compare Source](https://togithub.com/tinkurlab/monorepo-pr-labeler-action/compare/4.1.2...4.1.3)

Changes include:

Bug fix to ignore directories starting with a dot `.` but not directories that contain a dot `.`. According to the docs, this action should ignore mono repos that begin with a dot but it currently ignores also mono repo with a dot even if it is not the first character. Thanks to [@&#8203;MoLow](https://togithub.com/MoLow) for the fix!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #107
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants