Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in README #663

Closed
MikeMcC399 opened this issue Dec 12, 2022 · 2 comments
Closed

Broken links in README #663

MikeMcC399 opened this issue Dec 12, 2022 · 2 comments

Comments

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Dec 12, 2022

Description

Some links in README.md do not work.

Steps to reproduce the issue

Execute npm run check:markdown and look for Status 400 (Bad Request) and 404 (Not Found) errors.

  [✖] /examples/v10/component-tests/ → Status: 400
  [✖] #record-test-results-on-cypress-dashboard → Status: 404
  [✖] examples/start-and-yarn-workspaces → Status: 400

Note that executing npm run check:markdown will also show 403 Forbidden link errors for links to the github.com domain even though the links work when they are clicked on manually. This is a separate problem, which is described in issue #664.

Expected behavior

npm run check:markdown should not produce any 400 (Bad Request) or 404 (Not Found) errors.

Suggested Fixes

Correct the links in README.md as follows:

Old New
/examples/v10/component-tests/ examples/v10/component-tests/
#record-test-results-on-cypress-dashboard #record-test-results-on-cypress-cloud
examples/start-and-yarn-workspaces examples/v10/start-and-yarn-workspaces

Also update the README - Yarn workspaces example adding v10 to the working-directory.

@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Dec 12, 2022

@MikeMcC399
Copy link
Collaborator Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant