Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Artifact and video warnings in example-firefox #661

Closed
MikeMcC399 opened this issue Dec 12, 2022 · 1 comment
Closed

CI: Artifact and video warnings in example-firefox #661

MikeMcC399 opened this issue Dec 12, 2022 · 1 comment

Comments

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Dec 12, 2022

This is a follow-on from issue #659 "CI: Sporadic failures in example-firefox" regarding warnings coming from the workflow .github/workflows/example-firefox.yml.

Describe the bugs

  1. The v9 workflow fails to upload the screenshots collected during the test. The following warning is shown:
    "No files were found with the provided path: examples/firefox/cypress/screenshots. No artifacts will be uploaded.".
    See the Annotations warning from Run: 3643305659.

  2. The logs from both v9 and v10 workflows show the message:
    "Warning: We failed processing this video."
    See the log from Job: 6151396651, select and expand "Firefox". Scroll down to line 114.

Expected behavior

  1. Artifacts, which are the screenshots saved from the Cypress tests, from both v9 and v10 test should be uploaded.

  2. There should be no video warning.

Suggested fix

  1. In .github/workflows/example-firefox.yml for v9 change the artifacts upload path to examples/v9/firefox/cypress/screenshots so that it refers to the correct location where the screenshots to be uploaded are stored.

  2. In .github/workflows/example-firefox.yml for v10 change the artifacts upload name to screenshots-in-firefox-v10 to avoid the artifacts from the v10 test being overwritten by results from the v9 test.

  3. Since videos are not used in this example, disable videos to suppress the video-related warning. (For v9: add "video": false in cypress.json, for v10: add video: false in cypress.config.js.) This is a workaround for the known issue in Cypress: see Video functionality is not working on Firefox 93 and above cypress#18415. Videos are created by default, unless disabled, when Cypress is invoked with run - see Cypress documentation: Videos.

  4. For ease of local testing add a .gitignore file into the examples/v9/firefox and the examples/v10/firefox to instruct git to ignore node_modules/, cypress/screenshots/ and cypress/videos/ since the contents of these directories should not be committed. Edit: resolved by PR Correct .gitignore for videos and screenshots created by running examples #677.

@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Dec 12, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant