Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change recommendation for ci-build-id? #431

Open
rbayliss opened this issue Sep 28, 2021 · 1 comment
Open

Change recommendation for ci-build-id? #431

rbayliss opened this issue Sep 28, 2021 · 1 comment

Comments

@rbayliss
Copy link

Hello!
Thanks for this action! It looks like Github has recently added context support for github.run_attempt. This action currently has to do backflips with the GH API in order to generate a unique (but predictable) ci-build-id property, but with the addition of run_attempt, I think you could probably deprecate that complexity. Eg:

- name: E2E Tests
  uses: cypress-io/github-action@v2
  with:
    record: true
    parallel: true
    ci-build-id: "${{ github.repository }}-${{ github.run_id }}-${{ github.run_attempt}}"

I think this build ID would be guaranteed unique across all of Github for every run, even for reruns. github.run_attempt hasn't made the GHA documentation yet, so I'm not sure if it's stable enough to recommend right now, but I've verified that it's present for all of the current "Github Provided" runners.

@MikeMcC399
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants