From 680cec5cc908b86745afb2f0e362786d744a0cd4 Mon Sep 17 00:00:00 2001
From: Paul Jaffre <jaffrepaul@gmail.com>
Date: Mon, 21 Nov 2022 17:19:01 -0500
Subject: [PATCH] add node v18 to test matrix, remove deprecated v12

---
 .github/workflows/example-node-versions.yml |  4 +--
 .github/workflows/main.yml                  |  2 +-
 package-lock.json                           | 28 ++++++++++-----------
 package.json                                |  4 +--
 4 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/.github/workflows/example-node-versions.yml b/.github/workflows/example-node-versions.yml
index 65a06acf1..a9cfe927d 100644
--- a/.github/workflows/example-node-versions.yml
+++ b/.github/workflows/example-node-versions.yml
@@ -13,7 +13,7 @@ jobs:
     # let's make sure Cypress works on several versions of Node
     strategy:
       matrix:
-        node: [12, 14, 16]
+        node: [14, 16, 18]
     name: E2E on Node v${{ matrix.node }}
     steps:
       - name: Setup Node
@@ -39,7 +39,7 @@ jobs:
     # let's make sure Cypress works on several versions of Node
     strategy:
       matrix:
-        node: [12, 14, 16]
+        node: [14, 16, 18]
     name: E2E on Node v${{ matrix.node }}
     steps:
       - name: Setup Node
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index bfd9eb3d7..fe2650d8c 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        node: [12, 14, 16]
+        node: [14, 16, 18]
     name: Test on Node v${{ matrix.node }}
     steps:
       - name: Checkout
diff --git a/package-lock.json b/package-lock.json
index 8969bab52..f1f205fdf 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -23,8 +23,8 @@
         "quote": "0.4.0"
       },
       "devDependencies": {
-        "@types/node": "16.11.35",
-        "@vercel/ncc": "0.33.1",
+        "@types/node": "18.11.9",
+        "@vercel/ncc": "0.34.0",
         "husky": "7.0.4",
         "markdown-link-check": "3.10.2",
         "prettier": "2.6.2",
@@ -479,9 +479,9 @@
       }
     },
     "node_modules/@types/node": {
-      "version": "16.11.35",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.35.tgz",
-      "integrity": "sha512-QXu45LyepgnhUfnIAj/FyT4uM87ug5KpIrgXfQtUPNAlx8w5hmd8z8emqCLNvG11QkpRSCG9Qg2buMxvqfjfsQ=="
+      "version": "18.11.9",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.9.tgz",
+      "integrity": "sha512-CRpX21/kGdzjOpFsZSkcrXMGIBWMGNIHXXBVFSH+ggkftxg+XYP20TESbh+zFvFj3EQOl5byk0HTRn1IL6hbqg=="
     },
     "node_modules/@types/node-fetch": {
       "version": "2.5.12",
@@ -522,9 +522,9 @@
       }
     },
     "node_modules/@vercel/ncc": {
-      "version": "0.33.1",
-      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.33.1.tgz",
-      "integrity": "sha512-Mlsps/P0PLZwsCFtSol23FGqT3FhBGb4B1AuGQ52JTAtXhak+b0Fh/4T55r0/SVQPeRiX9pNItOEHwakGPmZYA==",
+      "version": "0.34.0",
+      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.34.0.tgz",
+      "integrity": "sha512-G9h5ZLBJ/V57Ou9vz5hI8pda/YQX5HQszCs3AmIus3XzsmRn/0Ptic5otD3xVST8QLKk7AMk7AqpsyQGN7MZ9A==",
       "dev": true,
       "bin": {
         "ncc": "dist/ncc/cli.js"
@@ -2550,9 +2550,9 @@
       }
     },
     "@types/node": {
-      "version": "16.11.35",
-      "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.35.tgz",
-      "integrity": "sha512-QXu45LyepgnhUfnIAj/FyT4uM87ug5KpIrgXfQtUPNAlx8w5hmd8z8emqCLNvG11QkpRSCG9Qg2buMxvqfjfsQ=="
+      "version": "18.11.9",
+      "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.9.tgz",
+      "integrity": "sha512-CRpX21/kGdzjOpFsZSkcrXMGIBWMGNIHXXBVFSH+ggkftxg+XYP20TESbh+zFvFj3EQOl5byk0HTRn1IL6hbqg=="
     },
     "@types/node-fetch": {
       "version": "2.5.12",
@@ -2592,9 +2592,9 @@
       }
     },
     "@vercel/ncc": {
-      "version": "0.33.1",
-      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.33.1.tgz",
-      "integrity": "sha512-Mlsps/P0PLZwsCFtSol23FGqT3FhBGb4B1AuGQ52JTAtXhak+b0Fh/4T55r0/SVQPeRiX9pNItOEHwakGPmZYA==",
+      "version": "0.34.0",
+      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.34.0.tgz",
+      "integrity": "sha512-G9h5ZLBJ/V57Ou9vz5hI8pda/YQX5HQszCs3AmIus3XzsmRn/0Ptic5otD3xVST8QLKk7AMk7AqpsyQGN7MZ9A==",
       "dev": true
     },
     "abort-controller": {
diff --git a/package.json b/package.json
index 3485c4112..68278c966 100644
--- a/package.json
+++ b/package.json
@@ -45,8 +45,8 @@
     "quote": "0.4.0"
   },
   "devDependencies": {
-    "@types/node": "16.11.35",
-    "@vercel/ncc": "0.33.1",
+    "@types/node": "18.11.9",
+    "@vercel/ncc": "0.34.0",
     "husky": "7.0.4",
     "markdown-link-check": "3.10.2",
     "prettier": "2.6.2",