feat(deps): electron@9.0.5 #7791

flotwig · 2020-06-23T19:32:36Z

Closes Cannot read property isAttached of undefined #6813
Closes Cypress devtool sometimes loses "developer tools" menu bar item #3559
Partially addresses Pdf does not preview in iframe in electron #2835

User facing changelog

Breaking Changes

libgbm-dev is now a requirement to run Cypress on Linux.

Bugfixes

Cypress will now properly run on Firefox versions >= 75.
The Developer Tools menu will now always display in Electron when switching focus from Specs to the Test Runner.

Dependency Updates

Upgraded Chrome browser version used during cypress run and when selecting Electron browser in cypress open from 80 to 83.
Upgraded bundled Node.js version from 12.8.1 to 12.14.1.
Upgraded electron from 8.3.1 to 9.0.5.

Additional details

also converted lib/gui/windows to typescript

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has the original issue been tagged with a release in ZenHub?
Has a PR for user-facing changes been opened in cypress-documentation? docs: note updated Electron libgbm req cypress-documentation#2931
[na] Have API changes been updated in the type definitions?
[na] Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2020-06-23T19:32:38Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

BREAKING CHANGE: libgbm is a requirement

cypress · 2020-06-23T19:50:49Z

Test summary

7657 • 0 • 119 • 0

Run details


Project	cypress
Status	Passed
Commit	`af4e3e4`
Started	Jun 29, 2020 4:15 PM
Ended	Jun 29, 2020 4:21 PM
Duration	06:03 💡
OS	Linux Debian - 10.2
Browser	Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

``` node version: v12.14.1 npm version: 6.14.5 yarn version: 1.22.4 debian version: 10.2 Chrome version: Google Chrome 83.0.4103.61 Firefox version: Mozilla Firefox 77.0 git version: git version 2.20.1 whoami: root ``` pre-req for Electron 9 upgrade cypress-io/cypress#7791

global extension loading was deprecated in 9, now has to be per-session

see benmalka/foxdriver#7

see cypress-io/cypress-docker-images#332

jennifer-shehane

So I was just trying to check if this magically fixed some Electron bug I was looking at, but Cypress crashed with yarn start.

I updated my Node.js and ran yarn prior.

 yarn start
yarn run v1.22.0
$ yarn ensure-deps
$ ./scripts/ensure-dependencies.sh
success Folder in sync.
$ node $(yarn bin cypress) open --dev --global
(node:28178) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:174:11)
    at new Buffer (buffer.js:257:3)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/lib/is-binary.js:2:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/index.js:10:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugin-print/dist/index.js:16:42)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugins/dist/index.js:44:43)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/jimp/dist/index.js:14:39)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/screenshots.js:6:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/screenshot.js:1:21)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/index.js:5:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/project.js:27:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/gui/events.js:17:17)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:11:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:14)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Function.Promise.attempt.Promise.try (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/method.js:39:29)
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at PromiseArray._resolve (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:127:19)
    at PromiseArray._promiseFulfilled (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:145:14)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:609:26)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at /Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/nodeback.js:42:21
    at FSReqCallback.oncomplete (fs.js:146:23)

TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
✨  Done in 5.96s.

DEBUG log

DEBUG=cypress:* yarn start
yarn run v1.22.0
$ yarn ensure-deps
$ ./scripts/ensure-dependencies.sh
success Folder in sync.
$ node $(yarn bin cypress) open --dev --global
  cypress:cli:cli cli starts with arguments ["/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node","/Users/jennifer/Dev/cypress/node_modules/.bin/cypress","open","--dev","--global"] +0ms
  cypress:cli NODE_OPTIONS is not set +0ms
  cypress:cli:cli program parsing arguments +2ms
  cypress:cli:cli opening Cypress +3ms
  cypress:cli parsed cli options { dev: true, global: true } +684ms
  cypress:cli opening from options {"dev":true,"global":true} +0ms
  cypress:cli command line arguments [] +0ms
  cypress:cli needs to start own Xvfb? false +0ms
  cypress:cli spawning, should retry on display problem? false +0ms
  cypress:cli in dev mode the args became [ '/Users/jennifer/Dev/cypress/scripts/start.js', '--', '--cwd', '/Users/jennifer/Dev/cypress' ] +1ms
  cypress:cli spawning Cypress with executable: node +7ms
  cypress:cli spawn args [ '/Users/jennifer/Dev/cypress/scripts/start.js', '--', '--cwd', '/Users/jennifer/Dev/cypress' ] { detached: false, stdio: 'inherit' } +1ms
  cypress:ts register TypeScript project /Users/jennifer/Dev/cypress/packages/ts/tsconfig.json fast? true +0ms
  cypress:server:util:node_options NODE_OPTIONS check passed, not forking { NODE_OPTIONS: '--max-http-header-size=1048576 --http-parser=legacy' } +0ms
  cypress:server:util:node_options not restoring NODE_OPTIONS since not yet in Electron +2ms
  cypress:server environment error Cannot read property 'commandLine' of undefined +0ms
  cypress:server:cypress starting cypress with argv [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js', '--', '--cwd', '/Users/jennifer/Dev/cypress' ] +0ms
  cypress:server:args argv array: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js', '--cwd', '/Users/jennifer/Dev/cypress' ] +0ms
  cypress:server:args argv parsed: { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true } +4ms
  cypress:server:util:proxy found proxy environment variables {} +0ms
  cypress:server:args options { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +2ms
  cypress:server:args argv options: { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +0ms
  cypress:server:cypress from argv [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js', '--cwd', '/Users/jennifer/Dev/cypress' ] got options { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +7ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +0ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +1ms
  cypress:server:appdata symlink folder from /Users/jennifer/Library/Application Support/Cypress/cy to /Users/jennifer/Dev/cypress/packages/server/.cy +0ms
  cypress:server:cypress starting in mode interactive with options { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +26ms
  cypress:server:cypress starting Electron +1ms
  cypress:server:cypress electron open arguments [ '--config={}', '--cwd=/Users/jennifer/Dev/cypress' ] +15ms
  cypress:electron opening . +0ms
  cypress:electron appPath /Users/jennifer/Dev/cypress/packages/server +0ms
  cypress:electron dest path /Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/Resources/app +0ms
  cypress:electron appPath exists /Users/jennifer/Dev/cypress/packages/server +1ms
  cypress:electron making symlink from /Users/jennifer/Dev/cypress/packages/server to /Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/Resources/app of type dir +0ms
  cypress:electron spawning /Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress with args [
  '--max-http-header-size=1048576 --http-parser=legacy',
  '--config={}',
  '--cwd=/Users/jennifer/Dev/cypress'
] +2ms
  cypress:ts register TypeScript project /Users/jennifer/Dev/cypress/packages/ts/tsconfig.json fast? true +0ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development/browsers +0ms
  cypress:server:util:node_options NODE_OPTIONS check passed, not forking { NODE_OPTIONS: '--max-http-header-size=1048576 --http-parser=legacy' } +0ms
  cypress:server:util:node_options restoring NODE_OPTIONS { NODE_OPTIONS: '--max-http-header-size=1048576 --http-parser=legacy', ORIGINAL_NODE_OPTIONS: undefined } +2ms
  cypress:server:cypress starting cypress with argv [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress', '--max-http-header-size=1048576 --http-parser=legacy', '--config={}', '--cwd=/Users/jennifer/Dev/cypress', '--enable-logging' ] +0ms
  cypress:server:args argv array: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress', '--max-http-header-size=1048576 --http-parser=legacy', '--config={}', '--cwd=/Users/jennifer/Dev/cypress', '--enable-logging' ] +0ms
  cypress:server:args argv parsed: { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: '{}', cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +4ms
  cypress:server:util:proxy found proxy environment variables {} +0ms
  cypress:server:args options { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +1ms
  cypress:server:args argv options: { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +1ms
  cypress:server:cypress from argv [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress', '--max-http-header-size=1048576 --http-parser=legacy', '--config={}', '--cwd=/Users/jennifer/Dev/cypress', '--enable-logging' ] got options { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +7ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +381ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +1ms
  cypress:server:appdata symlink folder from /Users/jennifer/Library/Application Support/Cypress/cy to /Users/jennifer/Dev/cypress/packages/server/.cy +0ms
  cypress:server:cypress starting in mode interactive with options { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +162ms
  cypress:server:cypress running Electron currently +1ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +80ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development/cache +891ms
(node:30241) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:174:11)
    at new Buffer (buffer.js:257:3)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/lib/is-binary.js:2:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/index.js:10:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugin-print/dist/index.js:16:42)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugins/dist/index.js:44:43)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/jimp/dist/index.js:14:39)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/screenshots.js:6:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/screenshot.js:1:21)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/index.js:5:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/project.js:27:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/gui/events.js:17:17)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:11:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:14)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Function.Promise.attempt.Promise.try (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/method.js:39:29)
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at PromiseArray._resolve (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:127:19)
    at PromiseArray._promiseFulfilled (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:145:14)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:609:26)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at /Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/nodeback.js:42:21
    at FSReqCallback.oncomplete (fs.js:146:23)

  cypress:server:saved_state making saved state from /Users/jennifer/Dev/cypress/packages/server +0ms
  cypress:server:saved_state missing project path, looking for project here +0ms
  cypress:server:saved_state state path for global mode +1ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +4s
  cypress:server:saved_state full state path /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:saved_state making new state file around /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file get values from /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file attempt to get lock on /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +1ms
  cypress:server:file getting lock succeeded or failed for /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +4ms
  cypress:server:file read /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file read succeeded or failed for /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +2ms
  cypress:server:file attempt to unlock /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file unlock succeeded or failed for /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +1ms
  cypress:server:windows creating electron window with options { backgroundColor: '#dfe2e4', width: 857, height: 620, minWidth: 458, minHeight: 400, x: 400, y: 141, type: 'INDEX', devTools: false, trackState: { width: 'appWidth', height: 'appHeight', x: 'appX', y: 'appY', devTools: 'isAppDevToolsOpen' }, onBlur: [Function: onBlur], onFocus: [Function: onFocus], onClose: [Function: onClose], show: true, frame: true, transparent: false, webPreferences: { preload: '/Users/jennifer/Dev/cypress/packages/server/lib/ipc/ipc.js', partition: null, webSecurity: false, nodeIntegration: false, backgroundThrottling: false, backgroundColor: '#dfe2e4', transparent: false }, url: 'file:///Users/jennifer/Dev/cypress/packages/desktop-gui/dist/index.html', contextMenu: false, recordFrameRate: null, onCrashed: [Function: onCrashed], onNewWindow: [Function: onNewWindow] } +0ms
TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
  cypress:electron electron closing { code: 0, errCode: null } +8s
  cypress:electron calling callback with code 0 +0ms
  cypress:server:cypress electron finished with 0 +8s
  cypress:cli child event fired { event: 'exit', code: 0, signal: null } +10s
  cypress:cli child event fired { event: 'close', code: 0, signal: null } +1ms
✨  Done in 17.57s.

flotwig · 2020-06-26T13:12:23Z

@jennifer-shehane Fixed, seems to have affected open mode only. Nice find. We should probably add some light e2e testing of the open mode one day, it would have caught that bug.

jennifer-shehane

Was trying out some of our open Electron issues to see if this PR resolves any of them. Turns out it does (added them to main PR comment).

Fixes issue where Developer Tools menu would disappear in Electron Cypress devtool sometimes loses "developer tools" menu bar item #3559
Halfway addresses issue where pdf in-viewers would prompt for download Pdf does not preview in iframe in electron #2835 (comment)
@flotwig Did you try Alpine Linux with this version update of Electron? Alpine Linux support #419 (comment)
Maybe also can you see if you can reproduce this SIGABRT issue / is it fixed in the Electron upgrade? SIGABRT exit a the end of CI run #5965 (comment)

Still getting this deprecation warning on yarn start. Is there any way to get rid of this or will this already be hidden to the user?

(node:37983) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:174:11)
    at new Buffer (buffer.js:257:3)
    at updateOutput (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:527:21)
    at Object.compile (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:514:20)
    at Module.m._compile (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:400:43)
    at Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Object.require.extensions.<computed> [as .ts] (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:403:12)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)

flotwig · 2020-06-29T13:20:39Z

@jennifer-shehane Seems to be caused by a usage of new Buffer inside of ts-node, but we only use it in development, so users won't see it. I requested renovate-bot to open a PR to update ts-node.

flotwig · 2020-06-29T13:22:02Z

Oh, I take it back, we'll need to upgrade ts-node since it's used to load user TS files. Still, shouldn't block this PR.

flotwig · 2020-06-29T13:30:49Z

Wow, we actually have 3 different versions of ts-node. The one in @packages/ts is the one causing the warning, and since we don't use that specific version of ts-node in prod, it's fine for now, only developers will see the deprecation notice.

Dismissing my previous reviews as addressed

cypress-bot · 2020-08-20T06:43:52Z

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

flotwig mentioned this pull request Jun 23, 2020

chore(deps): update dependency electron to version .x 🌟 #7405

Closed

1 task

chore(deps): electron@9.0.5

f5eae48

BREAKING CHANGE: libgbm is a requirement

flotwig force-pushed the electron-9 branch from d4f884e to f5eae48 Compare June 23, 2020 19:33

flotwig changed the base branch from develop to v5.0-release June 23, 2020 19:33

flotwig added the type: breaking change Requires a new major release version label Jun 23, 2020

flotwig mentioned this pull request Jun 24, 2020

base 12.14.1 cypress-io/cypress-docker-images#329

Merged

flotwig added 2 commits June 24, 2020 11:28

update node, xcode, docker images

6dfd015

lockfile

b692cdf

flotwig mentioned this pull request Jun 24, 2020

browsers/node12.14.1-chrome83-ff77 cypress-io/cypress-docker-images#330

Merged

flotwig added 7 commits June 24, 2020 12:16

chore(types): tsify lib/gui/windows and spec

f34576a

fix Electron extension loading

c8af048

global extension loading was deprecated in 9, now has to be per-session

make windows fns stubbable

75823ac

update electron_spec

83d6ea5

tsify issue_173_spec

d4be205

use upstream foxdriver to fix FF >= 75

1687f57

see benmalka/foxdriver#7

update test

aea2159

This was referenced Jun 25, 2020

add libgbm-dev to 8.0.0 base image cypress-io/cypress-docker-images#332

Closed

docs: note updated Electron libgbm req cypress-io/cypress-documentation#2931

Merged

flotwig changed the title ~~chore(deps): electron@9.0.5~~ feat(deps): electron@9.0.5 Jun 25, 2020

flotwig force-pushed the electron-9 branch from f96eba7 to 1621e08 Compare June 25, 2020 20:38

for now, install libgbm-dev at ci time

97cc6e0

see cypress-io/cypress-docker-images#332

flotwig force-pushed the electron-9 branch from 1621e08 to 97cc6e0 Compare June 25, 2020 20:49

flotwig marked this pull request as ready for review June 25, 2020 21:02

flotwig requested review from a team, brian-mann and kuceb and removed request for a team June 25, 2020 21:03

flotwig mentioned this pull request Jun 26, 2020

feat: v5.0 release #7753

Merged

21 tasks

jennifer-shehane requested changes Jun 26, 2020

View reviewed changes

fix open mode

fa1cdb6

flotwig requested a review from jennifer-shehane June 26, 2020 13:12

This was referenced Jun 29, 2020

Cypress devtool sometimes loses "developer tools" menu bar item #3559

Closed

Pdf does not preview in iframe in electron #2835

Closed

jennifer-shehane previously requested changes Jun 29, 2020

View reviewed changes

flotwig requested a review from jennifer-shehane June 29, 2020 13:30

flotwig mentioned this pull request Jun 29, 2020

Alpine Linux support #419

Open

remove devtools-ext dir

af4e3e4

brian-mann approved these changes Jun 29, 2020

View reviewed changes

brian-mann merged commit ffcb036 into v5.0-release Jun 29, 2020

jennifer-shehane mentioned this pull request Jul 7, 2020

Cannot read property isAttached of undefined #6813

Closed

cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020

flotwig deleted the electron-9 branch January 24, 2022 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(deps): electron@9.0.5 #7791

feat(deps): electron@9.0.5 #7791

flotwig commented Jun 23, 2020 •

edited by jennifer-shehane

cypress-bot bot commented Jun 23, 2020

cypress bot commented Jun 23, 2020 •

edited

jennifer-shehane left a comment

flotwig commented Jun 26, 2020

jennifer-shehane left a comment •

edited

flotwig commented Jun 29, 2020

flotwig commented Jun 29, 2020

flotwig commented Jun 29, 2020

cypress-bot bot commented Aug 20, 2020

feat(deps): electron@9.0.5 #7791

feat(deps): electron@9.0.5 #7791

Conversation

flotwig commented Jun 23, 2020 • edited by jennifer-shehane

User facing changelog

Breaking Changes

Bugfixes

Dependency Updates

Additional details

How has the user experience changed?

PR Tasks

cypress-bot bot commented Jun 23, 2020

cypress bot commented Jun 23, 2020 • edited

Test summary

Run details

jennifer-shehane left a comment

Choose a reason for hiding this comment

flotwig commented Jun 26, 2020

jennifer-shehane left a comment • edited

Choose a reason for hiding this comment

flotwig commented Jun 29, 2020

flotwig commented Jun 29, 2020

flotwig commented Jun 29, 2020

cypress-bot bot commented Aug 20, 2020

flotwig commented Jun 23, 2020 •

edited by jennifer-shehane

cypress bot commented Jun 23, 2020 •

edited

jennifer-shehane left a comment •

edited