From 1879066fdb2b6d116cb9e9068cdcfbae4580dc8e Mon Sep 17 00:00:00 2001 From: elevatebart Date: Wed, 18 May 2022 14:32:43 -0500 Subject: [PATCH 01/13] refactor: try removing the safelist --- .../frontend-shared/.windicss/safelist.ts | 27 ------------------- packages/frontend-shared/windi.config.ts | 2 -- 2 files changed, 29 deletions(-) delete mode 100644 packages/frontend-shared/.windicss/safelist.ts diff --git a/packages/frontend-shared/.windicss/safelist.ts b/packages/frontend-shared/.windicss/safelist.ts deleted file mode 100644 index eb8fedc5cb26..000000000000 --- a/packages/frontend-shared/.windicss/safelist.ts +++ /dev/null @@ -1,27 +0,0 @@ -/** - * WindiCSS will strip out any styles that aren't used. - * We do a lot of dynamic stuff, and we're not too concerned - * ith bundle size, so this is a pretty greedy list - */ -import { colors } from './colors' -import { map, reduce, kebabCase } from 'lodash' - -const textSafelist = ['xs', 'sm', 'lg', 'xl', '2xl', '3xl', '4xl', '5xl', '6xl'].map((v) => `text-${v}`).join(' ') -const colorSafelist = reduce(colors, (acc, variants, colorName) => { - const name = kebabCase(colorName) - - return `${acc} - ${map(variants, (_: string, k: string) => { - if (k === 'DEFAULT') return `` - - return ` - icon-light-${name}-${k} - icon-dark-${name}-${k} - bg-${name}-${k} - text-${name}-${k} - before:bg-${name}-${k} - before:text-${name}-${k}` - }).join(' ')}` -}, '') - -export const safelist = `${textSafelist} ${colorSafelist}` diff --git a/packages/frontend-shared/windi.config.ts b/packages/frontend-shared/windi.config.ts index 629004480957..385d98ab2c54 100644 --- a/packages/frontend-shared/windi.config.ts +++ b/packages/frontend-shared/windi.config.ts @@ -1,7 +1,6 @@ import { defineConfig } from 'windicss/helpers' import InteractionVariants from '@windicss/plugin-interaction-variants' import { IconDuotoneColorsPlugin } from './.windicss/icon-color-plugins' -import { safelist } from './.windicss/safelist' import { colors } from './.windicss/colors' import { shortcuts } from './.windicss/shortcuts' import path from 'path' @@ -28,7 +27,6 @@ export const defaultConfig: FullConfig = { }, }, }, - safelist, variants: { // What's hocus? // Hocus is a portmanteau of hover + focus. This is useful because From 74ee30ddeb98596ab088e77b848cbd2f68f78faa Mon Sep 17 00:00:00 2001 From: elevatebart Date: Wed, 18 May 2022 16:03:04 -0500 Subject: [PATCH 02/13] fix open browser bugs --- packages/launchpad/src/setup/OpenBrowserList.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/launchpad/src/setup/OpenBrowserList.vue b/packages/launchpad/src/setup/OpenBrowserList.vue index c148501549e1..420c854abcc7 100644 --- a/packages/launchpad/src/setup/OpenBrowserList.vue +++ b/packages/launchpad/src/setup/OpenBrowserList.vue @@ -53,8 +53,8 @@ >
{{ browser.displayName }}
From c23cf6fdccbe205ccf15b436ad4f6b4c151b67ab Mon Sep 17 00:00:00 2001 From: elevatebart Date: Thu, 19 May 2022 09:30:18 -0500 Subject: [PATCH 03/13] add ts in windi observed files --- packages/frontend-shared/windi.config.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/frontend-shared/windi.config.ts b/packages/frontend-shared/windi.config.ts index 385d98ab2c54..2b40b16436a8 100644 --- a/packages/frontend-shared/windi.config.ts +++ b/packages/frontend-shared/windi.config.ts @@ -44,9 +44,9 @@ export const defaultConfig: FullConfig = { include: [ 'index.html', '**/*.{vue,html,tsx}', - path.resolve(__dirname, '../frontend-shared/**/*.{vue,html,tsx,svg}'), - path.resolve(__dirname, '../app/**/*.{vue,html,tsx,svg}'), - path.resolve(__dirname, '../launchpad/**/*.{vue,html,tsx,svg}'), + path.resolve(__dirname, '../frontend-shared/**/*.{vue,html,tsx,ts,svg}'), + path.resolve(__dirname, '../app/**/*.{vue,html,tsx,ts,svg}'), + path.resolve(__dirname, '../launchpad/**/*.{vue,html,tsx,ts,svg}'), ], exclude: ['node_modules/**/*', '.git/**/*'], }, From 7f7b337763179c7622fa6d7ab04fb1652d4b948b Mon Sep 17 00:00:00 2001 From: elevatebart Date: Thu, 19 May 2022 09:41:18 -0500 Subject: [PATCH 04/13] resolve typescript issue --- packages/frontend-shared/src/gql-components/topnav/TopNav.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/frontend-shared/src/gql-components/topnav/TopNav.vue b/packages/frontend-shared/src/gql-components/topnav/TopNav.vue index 50f2483519f7..fcd4eb48bef5 100644 --- a/packages/frontend-shared/src/gql-components/topnav/TopNav.vue +++ b/packages/frontend-shared/src/gql-components/topnav/TopNav.vue @@ -106,11 +106,12 @@ >