Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify coffee fixtures / convert others #9433

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 3, 2020

User Changelog

N/A

Additional Details

  • rename fixtures that are required to be coffee files for tests (so we don’t try to convert them in future)
  • convert fixture that is not required to be coffee to js
  • update comments in code to reference .js files (so I’ll stop searching for these references)

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 3, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 3, 2020



Test summary

9104 0 118 3Flakiness 2


Run details

Project cypress
Status Passed
Commit 6baadd2
Started Dec 3, 2020 3:59 PM
Ended Dec 3, 2020 4:11 PM
Duration 12:11 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes
commands/net_stubbing_spec.ts Flakiness
1 network stubbing > stubbing with static responses > still works after a cy.visit

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb kuceb force-pushed the remove-remaining-coffee-tests-3 branch from 249931c to 6baadd2 Compare December 3, 2020 15:50
@kuceb
Copy link
Contributor

kuceb commented Dec 3, 2020

removed eslint-disable comment

@jennifer-shehane jennifer-shehane merged commit 0243c4d into develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants