Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net-stubbing): do not fireChangeEvent for non-existing routes #9425

Merged
merged 1 commit into from
Dec 3, 2020
Merged

fix(net-stubbing): do not fireChangeEvent for non-existing routes #9425

merged 1 commit into from
Dec 3, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Dec 2, 2020 •
edited

User facing changelog

  • Fixed a race condition that could cause an unexpected "Cannot read property "fireChangeEvent" of undefined" error when using cy.intercept.

Additional details

  • if an intercepted request is received at the end of a test, it is possible for a race condition to occur where the server sends an http:request:received event that has no handler in the driver
  • this was gracefully handled, but there were no tests around it, leading to this regression
  • fixed, and also added tests for unexpected http:response:received and http:request:complete

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 2, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 2, 2020 •
edited


Test summary

3929 • 0 • 49 • 2

Run details
Project cypress
Status Passed
Commit 46f212d
Started Dec 2, 2020 6:32 PM
Ended Dec 2, 2020 6:42 PM
Duration 09:42 💡
OS Linux Debian - 10.5
Browser Chrome 83

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig requested a review from kuceb December 2, 2020 19:10
kuceb
kuceb approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 tests with the same name, but lgtm

@flotwig
Copy link
Contributor Author

flotwig commented Dec 3, 2020

they have different names, go and have your morning ☕

@flotwig flotwig merged commit c42667e into develop Dec 3, 2020
@cypress-bot cypress-bot bot mentioned this pull request Dec 3, 2020
Closed
@kuceb
Copy link
Contributor

kuceb commented Dec 3, 2020

@flotwig great to see you fixed that, thanks for renaming them

@flotwig flotwig deleted the issue-9170 branch January 24, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuceb kuceb kuceb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property "fireChangeEvent" of undefined when stubbing with route2 in Chrome
2 participants
@flotwig @kuceb