chore: decaffeinate server tests w/in fixtures/projects (not e2e) #9154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jennifer-shehane
force-pushed
the
remove-remaining-coffee-tests-2
branch
4 times, most recently
from
ed89c13
to
7518e8d
Compare
jennifer-shehane
force-pushed
the
remove-remaining-coffee-tests-2
branch
from
7518e8d
to
52dc03b
Compare
|
These kitchensink tests are failing from 6.0 cy.intercept changes. I don't want to merge in develop because it always messes up the commits on decaffeinate files, so ignore the failures. |
kuceb
force-pushed
the
remove-remaining-coffee-tests-2
branch
from
52dc03b
to
ad9cf6c
Compare
|
force pushed to remove unneeded eslint-disable messages |
kuceb
previously approved these changes
Dec 3, 2020
cleanup js file references Convert missed coffee file Cleanup js Cleanup js Clean up js files Clean up js files Clean up js files Clean up js files
kuceb
force-pushed
the
remove-remaining-coffee-tests-2
branch
from
ad9cf6c
to
13580a8
Compare
|
rebased on develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decaffeinating some of the leftover coffeescript files in the server tests
DO NOT SQUASH
DO NOT MERGE IN DEVELOP
These kitchensink tests are failing from 6.0 cy.intercept changes. I don't want to merge in develop because it always messes up the commits on decaffeinate files, so ignore the failures.