-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat: take Firefox support out of beta #8586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo, nice catch, thanks |
wow, our tests really do not like FF 81... |
@bkucera the e2e test failures seem to be related to an issue with video recording and Firefox 80, not specifically related to this PR. I am able to reproduce failures in
So for this PR let's not bump the docker image. I'll create a new issue for this. |
@bkucera i've completed testing this PR against the memory leak repro we have in 1_firefox spec. Here are the results + videos running in a Fedora VM with 3GB of RAM:
I believe that this confirms that Mozilla fixed the memory leak as of FF 80, and also confirms that this PR still appropriately handles forced GC for older versions of Firefox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
firefoxGcInterval
behind version switch #8241User facing changelog
firefoxGcInterval
workaround to only apply to versions of Firefox older than 80. A warning will be presented if an older version is used.Additional details
New warning:
(note, the BrowserIcon for Custom Firefox is wrong (?)... not related to these changes)
How has the user experience changed?
PR Tasks
cypress-documentation
? docs: remove Firefox beta status, update firefoxGcInterval docs cypress-documentation#3168type definitions
?cypress.schema.json
?