Skip to content

feat: take Firefox support out of beta #8586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 25, 2020
Merged

feat: take Firefox support out of beta #8586

merged 6 commits into from
Sep 25, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Sep 15, 2020

User facing changelog

  • Firefox support is now out of beta!
  • Updated firefoxGcInterval workaround to only apply to versions of Firefox older than 80. A warning will be presented if an older version is used.

Additional details

New warning:

image

(note, the BrowserIcon for Custom Firefox is wrong (?)... not related to these changes)

How has the user experience changed?

PR Tasks

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 15, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 15, 2020



Test summary

8529 0 124 3


Run details

Project cypress
Status Passed
Commit 6b0291b
Started Sep 25, 2020 5:35 PM
Ended Sep 25, 2020 5:46 PM
Duration 11:26 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also claim firefox is in beta when we list supported browsers:
other than that looks good
image

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
@flotwig
Copy link
Contributor Author

flotwig commented Sep 22, 2020

oo, nice catch, thanks

@flotwig flotwig requested a review from kuceb September 23, 2020 15:20
@flotwig
Copy link
Contributor Author

flotwig commented Sep 23, 2020

wow, our tests really do not like FF 81...

@flotwig
Copy link
Contributor Author

flotwig commented Sep 23, 2020

@bkucera the e2e test failures seem to be related to an issue with video recording and Firefox 80, not specifically related to this PR. I am able to reproduce failures in develop by running 4_domain_spec with Firefox 79 (passes) and Firefox 80 (fails with video recording error from no frames).

4_domain_spec passing on develop by Firefox version:

headed headless
Firefox 79.0 ✔️ ✔️
Firefox 80.0

So for this PR let's not bump the docker image. I'll create a new issue for this.

@flotwig
Copy link
Contributor Author

flotwig commented Sep 25, 2020

@bkucera i've completed testing this PR against the memory leak repro we have in 1_firefox spec. Here are the results + videos running in a Fedora VM with 3GB of RAM:

  • Firefox 79 with forced GC disabled - invokes Fedora's OOM killer when system runs out of RAM, as expected
  • Firefox 79 - completes in 288 seconds with forced GC happening
  • Firefox 80 - completes in 208 seconds with NO forced GC
    • from the debug output (and the fact that it's ~40% faster) you can see that no forced GC is happening

I believe that this confirms that Mozilla fixed the memory leak as of FF 80, and also confirms that this PR still appropriately handles forced GC for older versions of Firefox.

Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take Firefox support out of beta; put firefoxGcInterval behind version switch
2 participants