Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Fix 5.0 spec duration always reporting as 0ms #8313

Merged
merged 3 commits into from Aug 18, 2020

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Aug 18, 2020

exists only in develop
fixes bug introduced by #8148 causing spec durations to be printed as 0ms in the final spec results.

fix #8309 (unreleased)

before:
image

after:
image

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 18, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 18, 2020



Test summary

8126 0 108 3


Run details

Project cypress
Status Passed
Commit 1aa178c
Started Aug 18, 2020 8:27 PM
Ended Aug 18, 2020 8:33 PM
Duration 06:36 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding
Copy link
Contributor

Looks like we do have a number of tests that take 0ms...

@bahmutov
Copy link
Contributor

the tests are too fast ...

@chrisbreiding
Copy link
Contributor

Looks like it happens when the tests don't even run because of a syntax error or plugins file error.

@bahmutov
Copy link
Contributor

@bkucera is this a wrong return from module API? maybe the module API test could just confirm it?

@kuceb
Copy link
Contributor Author

kuceb commented Aug 18, 2020

I requested the review too early, I'm fixing these now

@chrisbreiding chrisbreiding changed the title fix(server): 5.0 spec duration always reported as 0ms fix(server): Fix 5.0 spec duration always reporting as 0ms Aug 18, 2020
@chrisbreiding chrisbreiding merged commit 9a32d22 into develop Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 beta - missing test times in summary in console
3 participants