Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 beta - missing test times in summary in console #8309

Closed
lukeapage opened this issue Aug 18, 2020 · 7 comments · Fixed by #8313
Closed

v5 beta - missing test times in summary in console #8309

lukeapage opened this issue Aug 18, 2020 · 7 comments · Fixed by #8313
Assignees

Comments

@lukeapage
Copy link
Contributor

I've been trying out the latest master builds to see if I can get our tests upgraded to v5 and noticed this - found the same problem on your own builds.

Latest master branch build on windows:

https://ci.appveyor.com/project/cypress-io/cypress/builds/34714208/job/ip9ijo360b0w3ke5?fullLog=true

line 2080:

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  examples\actions.spec.js                   0ms       14       14        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\aliasing.spec.js                  0ms        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\assertions.spec.js                0ms        9        9        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\connectors.spec.js                0ms        8        8        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\cookies.spec.js                   0ms        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\cypress_api.spec.js               0ms       13       13        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\files.spec.js                     0ms        4        4        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\local_storage.spec.js             0ms        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\location.spec.js                  0ms        3        3        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\misc.spec.js                      0ms        6        6        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\navigation.spec.js                0ms        3        3        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\network_requests.spec.js          0ms        7        7        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\querying.spec.js                  0ms        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\spies_stubs_clocks.spec.js        0ms        7        7        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\traversal.spec.js                 0ms       18       18        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\utilities.spec.js                 0ms        6        6        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\viewport.spec.js                  0ms        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\waiting.spec.js                   0ms        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  examples\window.spec.js                    0ms        3        3        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        02:26      117      117        -        -        -  
yarn test-mocha

Notice how the times for each individual spec are 0ms - this used to show correct, not sure when it broke, we're stuck on 4.4.1 for performance reasons.

@bahmutov
Copy link
Contributor

Good eye @lukeapage thanks for reporting this

Individual spec has test durations


  (Run Starting)
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:    4.12.1                                                                             │
  │ Browser:    Chrome 84                                                                          │
  │ Specs:      19 found (examples\actions.spec.js, examples\aliasing.spec.js, examples\assertions │
  │             .spec.js, examples\connectors.spec.js, examples\cookies.spec.js, examples\cypress_ │
  │             api.spec.js, examples\files.spec.js, examples\local_storage.spec.js, examples\loca │
  │             tion.spec.j...)                                                                    │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  examples\actions.spec.js                                                       (1 of 19)
  Actions
    √ .type() - type into a DOM element (7573ms)
    √ .focus() - focus on a DOM element (628ms)
    √ .blur() - blur off a DOM element (964ms)
    √ .clear() - clears an input or textarea element (974ms)
    √ .submit() - submit a form (956ms)
    √ .click() - click on a DOM element (3009ms)
    √ .dblclick() - double click on a DOM element (646ms)
    √ .rightclick() - right click on a DOM element (763ms)
    √ .check() - check a checkbox or radio element (1608ms)
    √ .uncheck() - uncheck a checkbox element (1428ms)
    √ .select() - select an option in a <select> element (1503ms)
    √ .scrollIntoView() - scroll an element into view (609ms)
    √ .trigger() - trigger an event on a DOM element (482ms)
    √ cy.scrollTo() - scroll the window or element to a position (2595ms)
  14 passing (28s)
  (Results)

But the specs summary table at the end does not

@bahmutov
Copy link
Contributor

@bahmutov bahmutov self-assigned this Aug 18, 2020
@cypress-bot cypress-bot bot added the stage: investigating Someone from Cypress is looking into this label Aug 18, 2020
@bahmutov
Copy link
Contributor

before v5 merge 14e13f3 is working

Broken in v5 merge commit #7753

working in 27e8c81

working in 09c72e3

@bahmutov
Copy link
Contributor

working in 87029a7

working in f65a50f

@bahmutov
Copy link
Contributor

working in 01cc5e9

broken in commit that removes private properties from test results 966fbf0

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 18, 2020

The code for this is done in cypress-io/cypress#8313, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: investigating Someone from Cypress is looking into this label Aug 18, 2020
@jennifer-shehane
Copy link
Member

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v5.0.0, please open a new issue.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants