Skip to content

fix: Add reporter options #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Aug 17, 2020
Merged

fix: Add reporter options #8217

merged 31 commits into from
Aug 17, 2020

Conversation

admmasters
Copy link
Contributor

@admmasters admmasters commented Aug 7, 2020 •
edited by sync-by-unito bot
Loading

User facing changelog

adds reporterOptions to the typescript typings

Additional details

  • Change was needed so we can pass reporterOptions.
  • Adds the reporterOptions.
  • We are using a dictionary with a value of "any" to capture all the potential reporter options.

brian-mann and others added 26 commits October 23, 2019 18:00
@brian-mann
Merge branch 'develop'
b634486
@flotwig
Merge remote-tracking branch 'origin/develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
a0ef433
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
e629913
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
26c8e7f
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
876a86a
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
57c5b79
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
3c9ebf3
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
7d53c05
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
c1ddf3b
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
9103292
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
233defe
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
58be79a
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
34e67c8
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
f86c2c7
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
cfd2010
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
ae72127
@chrisbreiding
Merge branch 'develop'
6eeaf6f
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
e070acd
@chrisbreiding
Merge branch 'develop'
e313ca3
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
194e2c1
@chrisbreiding
Merge branch 'develop'
3dbb7ba
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
9933027
@chrisbreiding
Merge branch 'develop'
da7c6a1
@flotwig
Merge branch 'develop'

Verified

This commit was signed with the committer’s verified signature. The key has expired.
flotwig Zach Bloomquist
GPG key ID: DF3FE4F59D7B3361
Expired
Verified
Learn about vigilant mode
dc35752
@chrisbreiding
Merge branch 'develop'
7e82800
@admmasters
adds reporter options
0e6c303
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 7, 2020

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@admmasters admmasters mentioned this pull request Aug 7, 2020
Closed
jennifer-shehane
jennifer-shehane requested changes Aug 10, 2020
View reviewed changes
@jennifer-shehane jennifer-shehane changed the title Add reporter options fix: Add reporter options Aug 10, 2020
@sync-by-unito sync-by-unito bot changed the title fix: Add reporter options Add reporter options Aug 10, 2020
admmasters and others added 2 commits August 15, 2020 14:33
@admmasters @jennifer-shehane
Update cli/types/cypress.d.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2ed4069 
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@admmasters @jennifer-shehane
Update cli/types/cypress.d.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
520d863 
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@jennifer-shehane jennifer-shehane changed the title Add reporter options fix: Add reporter options Aug 17, 2020
@jennifer-shehane jennifer-shehane self-requested a review August 17, 2020 04:13
@jennifer-shehane
Update cli/types/cypress.d.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3553ffa
@jennifer-shehane
Copy link
Member

I'm going to merge this in - the build keeps failing for irrelevant reasons due to develop/5.0 release.

@jennifer-shehane jennifer-shehane merged commit 2f835f7 into cypress-io:develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane

Assignees

@jennifer-shehane jennifer-shehane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing reporterOptions from the ResolvedConfigOptions in cypress
6 participants
@admmasters @CLAassistant @jennifer-shehane @brian-mann @flotwig @chrisbreiding