Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add reporter options #8217

Merged
merged 31 commits into from Aug 17, 2020

Conversation

admmasters
Copy link
Contributor

@admmasters admmasters commented Aug 7, 2020

User facing changelog

adds reporterOptions to the typescript typings

Additional details

  • Change was needed so we can pass reporterOptions.
  • Adds the reporterOptions.
  • We are using a dictionary with a value of "any" to capture all the potential reporter options.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 7, 2020

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2020

CLA assistant check
All committers have signed the CLA.

cli/types/cypress.d.ts Outdated Show resolved Hide resolved
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
@jennifer-shehane jennifer-shehane changed the title Add reporter options fix: Add reporter options Aug 10, 2020
@sync-by-unito sync-by-unito bot changed the title fix: Add reporter options Add reporter options Aug 10, 2020
admmasters and others added 2 commits August 15, 2020 14:33
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@jennifer-shehane jennifer-shehane changed the title Add reporter options fix: Add reporter options Aug 17, 2020
@jennifer-shehane
Copy link
Member

I'm going to merge this in - the build keeps failing for irrelevant reasons due to develop/5.0 release.

@jennifer-shehane jennifer-shehane merged commit 2f835f7 into cypress-io:develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing reporterOptions from the ResolvedConfigOptions in cypress
6 participants