Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): Cannot set property 'err' of undefined on spec rerun due to file changes #8193

Merged
merged 3 commits into from Aug 6, 2020

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Aug 6, 2020

User facing changelog

  • Bug Fix: fix Cannot set property 'err' of undefined error on spec rerun due to file changes

Additional details

  • unregister mocha runner listeners after run completes to avoid timeout errors 'leaking'
  • found a way to write a failing test this time 👍
  • this didn't happen until recently because previously the error was still throwing but was caught due to being associated with the wrong test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 6, 2020

Thanks for taking the time to open a PR!

@kuceb kuceb changed the title fix: Cannot set property 'err' of undefined on spec rerun due to file changes fix(runner): Cannot set property 'err' of undefined on spec rerun due to file changes Aug 6, 2020
@cypress
Copy link

cypress bot commented Aug 6, 2020



Test summary

7931 0 130 2


Run details

Project cypress
Status Passed
Commit 82cd023
Started Aug 6, 2020 12:54 AM
Ended Aug 6, 2020 1:00 AM
Duration 06:04 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have fixed the original reproducible example at https://github.com/primitiveconcept/ludumdare46/tree/cypress/err-of-undefined/client - it used to be fairly easy to reproduce. Now running multiple times I don't see the error throwing.

Additionally the code provided does fix the test in this PR (which exhibits the 'Cannot set property err of undefined' error normally).

LGTM 👍

@Konradox
Copy link

Konradox commented Aug 6, 2020

Great! I'm waiting for the next release. This bug is not that critical but annoying. Thank you @bkucera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants