Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for Cookie interface expiry prop #8144

Closed
MattAndDev opened this issue Jul 31, 2020 · 2 comments · Fixed by #8145
Closed

Wrong type for Cookie interface expiry prop #8144

MattAndDev opened this issue Jul 31, 2020 · 2 comments · Fixed by #8145
Labels
topic: cookies 🍪 type: typings Issue related to Cypress types (for TypeScript)

Comments

@MattAndDev
Copy link
Contributor

MattAndDev commented Jul 31, 2020

Current behavior:

Cookie interface expiry prop is typed as string. But it's a number.
Also it's in unix epoch, might be wort. a line in the docs (:

Desired behavior:

Correct typings for expiry

Test code to reproduce

cy.setCookie('test', '1')
cy.getCookie('test')
  .then((cookie) => {
    expect(typeof cookie.expiry).to.equal('number')
})

Versions

@jennifer-shehane jennifer-shehane added topic: cookies 🍪 type: typings Issue related to Cypress types (for TypeScript) labels Jul 31, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jul 31, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 31, 2020

The code for this is done in cypress-io/cypress#8145, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 31, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2020

Released in 4.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.12.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: cookies 🍪 type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants