Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percy snapshot of internal Config test sometimes does not have config as opened. #8124

Closed
jennifer-shehane opened this issue Jul 30, 2020 · 5 comments · Fixed by #7753
Closed

Percy snapshot of internal Config test sometimes does not have config as opened. #8124

jennifer-shehane opened this issue Jul 30, 2020 · 5 comments · Fixed by #7753
Labels
process: flaky test Related to test(s) that have flake in our internal tests type: chore Work is required w/ no deliverable to end user

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jul 30, 2020 •
edited by sync-by-unito bot

Current behavior:

We're taking percy snapshots of the config in our Settings panel of the Desktop-GUI, but sometimes this screenshot is not correct (I've had to ignore 4+ times now) - it's not waiting for the panel to be opened. I don't understand how this is happening at all, it's almost as if the percy snapshot is being taken before the other commands run.

Failing percy https://percy.io/cypress-io/cypress/builds/6304631

We're asserting that the height of the element should be greater than 400, so why is this screenshot being taken before it is visually expanded.

Desired behavior:

Need consistent screenshots for screenshot diffing.

Versions

4.11.0
@jennifer-shehane jennifer-shehane added process: flaky test Related to test(s) that have flake in our internal tests type: chore Work is required w/ no deliverable to end user labels Jul 30, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jul 30, 2020
@dbudziwojski
Copy link

I can confirm that this behavior exists with Percy as well as with cy.screenshot() which ignores the preceding cy.wait() or a cy.get() (which does pass).

@jennifer-shehane
Copy link
Member Author

@StapleMink This is an issue related to our own internal tests and not the Cypress product itself.

If you have an issue relating to cy.screenshot() not performing as expected within the Cypress product itself, please open a new issue with a fully reproducible example that we can run.

@jennifer-shehane
Copy link
Member Author

This is assumed fixed in 5.0-branch here: 01cc5e9

@flotwig flotwig mentioned this issue Aug 12, 2020
Merged
21 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 13, 2020

The code for this is done in cypress-io/cypress#7753, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: ready for work The issue is reproducible and in scope label Aug 13, 2020
@jennifer-shehane
Copy link
Member Author

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v5.0.0, please open a new issue.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
process: flaky test Related to test(s) that have flake in our internal tests type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: v5.0 release cypress-io/cypress
2 participants
@jennifer-shehane @dbudziwojski