Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types not exported in .d.ts #7309

Closed
pedroclayman opened this issue May 12, 2020 · 5 comments · Fixed by #8096
Closed

Types not exported in .d.ts #7309

pedroclayman opened this issue May 12, 2020 · 5 comments · Fixed by #8096
Assignees
Labels
topic: typescript type: typings Issue related to Cypress types (for TypeScript)

Comments

@pedroclayman
Copy link

pedroclayman commented May 12, 2020

Current behavior:

The types declared in cypress-npm-api.d.ts cannot be used by calling code since they are not being exported.

Desired behavior:

The types should be exported in order to be usable.

Test code to reproduce

N/A

Versions

Cypress 4.5.0

@jennifer-shehane jennifer-shehane added the type: typings Issue related to Cypress types (for TypeScript) label May 12, 2020
@kyrstenkelly
Copy link

I also see this and it is causing issues.

Version: Cypress 4.5.0

Trying to record results via the Module API and running into this:

cypress.run({ env })
    .then((results: Cypress.CypressRunResults) => {
      logger.info(results.totalTests);
      logger.info(results.totalFailed);
    });

Results in:

error - Namespace 'Cypress' has no exported member 'CypressRunResults'.

@MCFreddie777
Copy link

MCFreddie777 commented Jul 13, 2020

Version: Cypress 4.10.0

Can we get an update on this? It's been already few minor versions since...

@cypress-bot cypress-bot bot added the stage: proposal 💡 No work has been done of this issue label Jul 14, 2020
@jennifer-shehane
Copy link
Member

We're open to PRs to implement this. Check out our contributing doc.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2020

The code for this is done in cypress-io/cypress#8096, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jul 29, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 3, 2020

Released in 4.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.12.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: typescript type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants