-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Don’t remove stack from uncaught errors #6965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed manually that the situations from the issue now show a proper stack trace to the specfile where the uncaught error is being thrown.
User facing changelog
How has the user experience changed?
Uncaught error - stdout before:
Uncaught error - stdout after:
Assertion error - stdout before:
Assertion error - stdout after:
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?