Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make adding sameSite value to objects yielded by cy.getCookie/setCookie/getCookies the default #6892

Closed
flotwig opened this issue Mar 31, 2020 · 2 comments · Fixed by #7790
Closed

Make adding sameSite value to objects yielded by cy.getCookie/setCookie/getCookies the default #6892

flotwig opened this issue Mar 31, 2020 · 2 comments · Fixed by #7790
Labels
type: breaking change Requires a new major release version type: feature New feature that does not currently exist

Comments

@flotwig
Copy link
Contributor

flotwig commented Mar 31, 2020

Remove the experimentalGetCookiesSameSite flag and make this behavior the default for all Cypress users.
@flotwig flotwig added the type: breaking change Requires a new major release version label Mar 31, 2020
@jennifer-shehane jennifer-shehane added the type: feature New feature that does not currently exist label Apr 1, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Apr 1, 2020
@flotwig flotwig mentioned this issue Jun 23, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jun 23, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 29, 2020

The code for this is done in cypress-io/cypress#7790, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 29, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: breaking change Requires a new major release version type: feature New feature that does not currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make cookies have sameSite key by default cypress-io/cypress
2 participants
@flotwig @jennifer-shehane