Using the [S] shortcut during a paused state produces some strange behavior

[Regnander]

Current behavior:

When cy.pause() is called the user is unable to press the stop button since it's not found in the toolbar in this state, so in order to stop the test, they must click the continue button to resume the test before being able to press the stop button:

However, if you use the stop shortcut (S), the test will stop and the reset button will show up in the toolbar alongside the continue button and the "PAUSED" badge as if Cypress just entered a limbo state between being paused and stopped:

From this point when you click the continue button, the test will remain stopped but the timer will start counting again as if the test is running:

Desired behavior:

I expected the shortcut to affect the toolbar the same way as the GUI button and remove the continue button.

Test code to reproduce

context('...', () => {
    it('...', () => {
        cy.pause()
        // Press [S] to stop the test here!
        cy.log('Hello world! 🖐')
    })
})

Versions

Cypress 4.2.0 (might work in earlier versions)
Windows 10
Electron (whatever version Cypress has)

[jennifer-shehane]

Yeah, definitely an edge case we did not consider. I can recreate this behavior from the provided test code above.

Original PR adding the keyboard shortcuts is here: #3943

Should likely disable the shortcut if paused.

[IvoKkk]

what?

…

On Sunday, April 19, 2020, irwan224-droid ***@***.***> wrote: Hacked XSS BY IrwanLx11 <http://x> <http://x> - — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6867 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APH7NQEDD4NWHBTAQKPIV23RNMNDDANCNFSM4LU65S5Q> .

-- null